Support code with prefixes

[alexgarel]

In:

• CSV Upload from Open Source Data to OFF Database - PLU codes #7735

We talk about supporting code with a prefix like: plu-66745

For this to happen:

• we have a function to normalize codes, it should be changed (see normalize_code in Products.pm) to support prefixes (ideally those prefixes should be validated against a list provided in configuration, see Config_off.pm)
• there might also be some cgi and scripts that does transformation manually (search for code + ""), while they should call the normalization function
• a search on the code without prefix should return the item (search for 4015 must return "plu-4015")
• write some integration test, because there might be some cgi file not using it (while they should). (see tests/integration there are some example test)
  • search a product with plu-xxxx code
  • search a product with xxxx code and get plu-xxxx
  • display a product with plu-xxxx code
  • edit a product with plu-xxxx code
    testing the API should be enough

[alexgarel]

@stephanegigandet on sure I'm not sure is if we want to populate the code_tags field, and how we should do that.

[FoodCoach-App]

@stephanegigandet @alexgarel

Based on the below example of the code-tags, I'd propose that the first code-tag should say PLU, price look up, or PLU-Commodity.

I don't understand the use of the cascading number of UPC digits in the example and can offer no suggestion there.

[alexgarel]

@FoodCoach-App is there some hierarchy coding in plu code ? (like a meaning for first, or second, etc. digits)

[FoodCoach-App]

Unlikely. In the PLU code, there are "zones" for each commodity (3100-3300 for example), but the first digit doesn't always mean A, and the second digit doesn't always mean B.

…

On Wed, Dec 14, 2022 at 5:21 AM Alex Garel ***@***.***> wrote: @FoodCoach-App <https://github.com/FoodCoach-App> is there some hierarchy coding in plu code ? (like a meaning for first, or second, etc. digits) — Reply to this email directly, view it on GitHub <#7806 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4J6ZUGBVORCAOS37HTIFXDWNGNTLANCNFSM6AAAAAASVMEBCM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[alexgarel]

If we have a list of suche zone, I think it's worth having the zone thing in the tags, coded as "plu-start-end".

For code 3241, we would have:

"code_tags": ["plu", "plu-3100-3300", "plu-3241"]

Otherwise just ["plu", "plu-3241"]

[FoodCoach-App]

@alexgarel

Each commodity has a different amount 4 digit number associated with them and start on different values.

The range was provided for background and to explain that there is no significance on a a digit-by-digit basis.

I would argue to move forward with: ["plu", "plu-3241"]

[github-actions]

This issue is stale because it has been open 90 days with no activity.