Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid false positive errors for low energy values #7811 #7864

Merged
merged 3 commits into from
Dec 20, 2022
Merged

fix: avoid false positive errors for low energy values #7811 #7864

merged 3 commits into from
Dec 20, 2022

Conversation

CharlesNepote
Copy link
Member

@CharlesNepote CharlesNepote requested a review from a team as a code owner December 20, 2022 13:56
@github-actions github-actions bot added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Dec 20, 2022
@CharlesNepote CharlesNepote changed the title fix: #7811 fix: avoid false positive errors for low energy values #7811 Dec 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@alexgarel alexgarel merged commit 10aec8e into main Dec 20, 2022
@alexgarel alexgarel deleted the Bug-7811 branch December 20, 2022 16:51
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@CharlesNepote CharlesNepote

Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

energy-value-in-kcal-does-not-match-value-in-kj: false positive for low values
2 participants
@CharlesNepote @alexgarel