Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean CORS handling #7901

Closed
alexgarel opened this issue Dec 23, 2022 · 2 comments
Closed

Clean CORS handling #7901

alexgarel opened this issue Dec 23, 2022 · 2 comments
Labels
CORS NGINX Sprint ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. ✅ Task

Comments

@alexgarel
Copy link
Member

As I tried to fix #7796 it took me a hard time understanding how we handled CORS.
(I must say it took me time to discover the -access_control_allow_origin headers…)

I finally decided to "clean the mess" and have a more sane handling of CORS headers.
@alexgarel alexgarel mentioned this issue Dec 23, 2022
Merged
alexgarel added a commit that referenced this issue Jan 6, 2023
@alexgarel
fix: Fix cors headers (#7900)
4aac6f6 
* centralize cors headers handling in perl code
* add Access-Control-Allow-Methods correctly
* add tests

* cleaned nginx prod configurations
* make docker nginx more close to production configuration

should fix:
- #7796
- #7901
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Jan 6, 2023
Merged
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Mar 24, 2023
@alexgarel
Copy link
Member Author

It's already done and merge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CORS NGINX Sprint ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. ✅ Task
Projects
Product Opener - Sprint
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexgarel