Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: Labels and categories additions #7910

Merged
merged 7 commits into from
May 2, 2023
Merged

taxonomy: Labels and categories additions #7910

merged 7 commits into from
May 2, 2023

Conversation

teolemon
Copy link
Member

What

  • Labels and categories additions

@github-actions github-actions bot added categories labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Dec 27, 2022
@teolemon teolemon changed the title Labels and categories additions taxonomy: Labels and categories additions Jan 4, 2023
@teolemon teolemon requested a review from a team January 4, 2023 17:05
@teolemon teolemon marked this pull request as ready for review January 5, 2023 10:38
stephanegigandet
stephanegigandet reviewed Jan 6, 2023
View reviewed changes
taxonomies/categories.txt Outdated
@@ -73257,6 +73257,10 @@ ciqual_food_code:en:6002
ciqual_food_name:en:Beef, shoulder, raw
ciqual_food_name:fr:Boeuf, épaule, crue

<en:Beef meat
en:Beef liver
fr:Foie de boeuf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

category names should be in plural (it's an issue for many CIQUAL categories that were added as singular); the singular should be added as a synonym

teolemon
teolemon commented Jan 10, 2023
View reviewed changes
taxonomies/categories.txt Outdated
Comment on lines 73260 to 73262
<en:Beef meat
en:Beef liver
fr:Foie de boeuf
Copy link
Member Author

@teolemon teolemon Jan 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<en:Beef meat
en:Beef liver
fr:Foie de boeuf
<en:Beef meat
en:Beef livers
fr:Foies de boeuf

teolemon
teolemon commented Jan 10, 2023
View reviewed changes
taxonomies/categories.txt Outdated
Comment on lines 73368 to 73370
<en:Beef meat
en:Beef liver
fr:Foie de boeuf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<en:Beef meat
en:Beef liver
fr:Foie de boeuf
<en:Beef meat
en:Beef livers
fr:Foies de boeuf

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Mar 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #7910 (920b6ff) into main (e0f97b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7910   +/-   ##
=======================================
  Coverage   48.16%   48.16%           
=======================================
  Files         109      109           
  Lines       21015    21015           
  Branches     4739     4739           
=======================================
  Hits        10122    10122           
  Misses       9618     9618           
  Partials     1275     1275

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benbenben2
Copy link
Collaborator

@teolemon , @stephanegigandet please review applied changes

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Apr 25, 2023
stephanegigandet
stephanegigandet approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@stephanegigandet stephanegigandet merged commit 1dc577d into main May 2, 2023
@stephanegigandet stephanegigandet deleted the labels-addition branch May 2, 2023 07:19
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@teolemon teolemon

Labels
categories labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teolemon @codecov-commenter @benbenben2 @stephanegigandet