Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: add some structure to data quality #8082

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

alexgarel
Copy link
Member

Add some structure to data quality.

Linked to #7718 and to PR #8032

@alexgarel alexgarel requested a review from a team as a code owner February 8, 2023 15:52
@github-actions github-actions bot added 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Feb 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #8082 (fd70155) into main (8a99b8f) will not change coverage.
The diff coverage is n/a.

❗ Current head fd70155 differs from pull request most recent head fce2c6d. Consider uploading reports for the commit fce2c6d to get more accurate results

@@           Coverage Diff           @@
##             main    #8082   +/-   ##
=======================================
  Coverage   45.20%   45.20%           
=======================================
  Files         102      102           
  Lines       20269    20269           
  Branches     4638     4638           
=======================================
  Hits         9163     9163           
  Misses      10010    10010           
  Partials     1096     1096           
Impacted Files Coverage Δ
lib/ProductOpener/DataQuality.pm 65.62% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@CharlesNepote CharlesNepote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

taxonomies/data_quality.txt Outdated Show resolved Hide resolved
taxonomies/data_quality.txt Outdated Show resolved Hide resolved
taxonomies/data_quality.txt Outdated Show resolved Hide resolved
taxonomies/data_quality.txt Outdated Show resolved Hide resolved
Co-authored-by: Charles Nepote <charles@nepote.org>
Co-authored-by: Divyansh Singh <divyanshanandsingh@gmail.com>
Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
@alexgarel
Copy link
Member Author

Thank you everybody for the attentive reviews ! @CharlesNepote can you approve ?

@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit 824f3df into main Feb 10, 2023
@alexgarel alexgarel deleted the taxonomy-data-quality-hierarchy branch February 10, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants