Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update welcome email #8703

Merged
merged 2 commits into from
Jul 21, 2023
Merged

fix: Update welcome email #8703

merged 2 commits into from
Jul 21, 2023

Conversation

raphael0202
Copy link
Contributor

@raphael0202 raphael0202 commented Jul 18, 2023 •
edited by teolemon
Loading

What

Part of

@raphael0202 raphael0202 requested a review from a team as a code owner July 18, 2023 15:42
@github-actions github-actions bot added 📚 Documentation Documentation issues improve the project for everyone. 🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 👥 Users 📨 Mail labels Jul 18, 2023
@raphael0202 raphael0202 mentioned this pull request Jul 18, 2023
Merged
alexgarel
alexgarel approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but some small suggestions. I let you apply them and merge.

Thanks a lot for this PR !

lib/ProductOpener/Mail.pm Outdated Show resolved Hide resolved
lib/ProductOpener/Mail.pm Outdated Show resolved Hide resolved
lib/ProductOpener/Mail.pm Outdated Show resolved Hide resolved
@raphael0202 raphael0202 enabled auto-merge (squash) July 21, 2023 09:46
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@raphael0202 raphael0202 merged commit b4edf99 into main Jul 21, 2023
15 of 16 checks passed
@raphael0202 raphael0202 deleted the update-welcome-email branch July 21, 2023 10:08
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jul 20, 2023
Merged
@stephanegigandet stephanegigandet mentioned this pull request Jul 25, 2023
Open
@teolemon teolemon mentioned this pull request Jul 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangy hangy hangy left review comments

@alexgarel alexgarel alexgarel approved these changes

Assignees

@raphael0202 raphael0202

Labels
📚 Documentation Documentation issues improve the project for everyone. 📨 Mail 🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 👥 Users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raphael0202 @hangy @alexgarel