Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: hr unknown ingred 4 #8739

Merged
merged 4 commits into from
Jul 31, 2023
Merged

taxonomy: hr unknown ingred 4 #8739

merged 4 commits into from
Jul 31, 2023

Conversation

benbenben2
Copy link
Collaborator

What

added Croatian ingredients into the taxonomies.

@benbenben2 benbenben2 requested a review from a team as a code owner July 25, 2023 20:00
@benbenben2 benbenben2 self-assigned this Jul 25, 2023
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients 🧪 additives 🥜 Allergens labels 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients - processing labels Jul 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8739 (edb8925) into main (b128504) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8739   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files         117      117           
  Lines       21882    21882           
  Branches     4869     4869           
=======================================
  Hits        10676    10676           
  Misses       9903     9903           
  Partials     1303     1303
Files Changed Coverage Δ
lib/ProductOpener/Ingredients.pm 90.80% <ø> (ø)
tests/unit/ingredients_processing.t 94.73% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

stephanegigandet
stephanegigandet approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 6943f02 into main Jul 31, 2023
15 checks passed
@stephanegigandet stephanegigandet deleted the tax_hr_unknown_ingred_4 branch July 31, 2023 11:33
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@benbenben2 benbenben2

Labels
🧪 additives 🥜 Allergens 🥗 Ingredients - processing 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbenben2 @codecov-commenter @stephanegigandet