Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translations for OPFF #8805

Merged
merged 4 commits into from
Aug 7, 2023
Merged

fix: translations for OPFF #8805

merged 4 commits into from
Aug 7, 2023

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Aug 7, 2023

What

fix: translations for OPFF

@teolemon teolemon requested a review from a team as a code owner August 7, 2023 15:49
@github-actions github-actions bot added 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels Aug 7, 2023
msgctxt "site_name"
msgid "Open Pet Food Facts"
msgstr "Open Pet Food Facts"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a value for en

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. Crowdin will autofix it anyway once we translate in English https://crowdin.com/project/openfoodfacts/en

@codecov-commenter
Copy link

Codecov Report

Merging #8805 (0816eea) into main (799f250) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8805   +/-   ##
=======================================
  Coverage   48.75%   48.75%           
=======================================
  Files         118      118           
  Lines       22000    22000           
  Branches     4888     4888           
=======================================
  Hits        10726    10726           
  Misses       9968     9968           
  Partials     1306     1306           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

po/openpetfoodfacts/en.po Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon merged commit 8aa9864 into main Aug 7, 2023
15 checks passed
@teolemon teolemon deleted the fixes branch August 7, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants