fix: do not use 'and' translations from Crowdin for ingredient analysis #8809
Conversation
github-actions
bot
added
🥗 Ingredients
🥗🔍 Ingredients analysis
| my $and = $Lang{_and_}{$lc}; | ||
| #my $enumeration_separators = $obrackets . '|' . $cbrackets . '|\/| \/ | ' . $dashes . ' |' . $commas . ' |' . $commas. '|' . $Lang{_and_}{$lc}; | ||
| # do not match anything if we don't have a translation for "and" | ||
| my $and = $and{$lc} || " will not match "; |
There was a problem hiding this comment.
it's a bit confusing to have $and named as %and… but it's ok.
Also we don't support a lot of languages in %and for now… shan't you report current translations in %and ?
grep -A 3 'msgctxt "_and_"' -r po/common/ |grep msgstr
There was a problem hiding this comment.
@alexgarel Nice, I never used the -A option :)
There was a problem hiding this comment.
I added some of the translations, and left out the ones for languages we have poor support (non roman characters mostly)
Codecov Report
@@ Coverage Diff @@
## main #8809 +/- ##
=======================================
Coverage 48.75% 48.75%
=======================================
Files 118 118
Lines 22000 22000
Branches 4888 4888
=======================================
Hits 10726 10726
Misses 9968 9968
Partials 1306 1306
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
Relying on translated strings from Crowdin for translation analysis (e.g. strings like "and") is too fragile, use translations from Ingredients.pm instead.
Fixes #8794