Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use path instead of txt in NOVA unknown icon, and fix size and font #9252

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Nov 7, 2023

fixes #9243 and also revert back to the original size and font of the other NOVA icons (changed in #8436 )

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet changed the title fix: use path instead of txt in NOVA unknown icon fix: use path instead of txt in NOVA unknown icon, and fix size and font Nov 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #9252 (28e4b07) into main (0d4a0f8) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9252   +/-   ##
=======================================
  Coverage   47.91%   47.91%           
=======================================
  Files          65       65           
  Lines       20277    20277           
  Branches     4916     4916           
=======================================
  Hits         9715     9715           
  Misses       9307     9307           
  Partials     1255     1255           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@alexgarel alexgarel merged commit df378c6 into main Nov 7, 2023
15 checks passed
@alexgarel alexgarel deleted the nova-unknown branch November 7, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: No status
Development

Successfully merging this pull request may close these issues.

Fix "Nova: unknown" logo with drawing instead of text
3 participants