Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: added anses tag in additives, added one allergen #9265

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

benbenben2
Copy link
Collaborator

@benbenben2 benbenben2 commented Nov 7, 2023

What

  • added anses tag in additives, first step of

    • add a property anses_additives_of_interest in the taxonomy.
    • count those additives in each product, in a new anses_additives_of_interest_n tag (similar to the existing additives_n tag)
    • use this data in the producers platform to signal those additives, and compare to similar products from other categories
  • added one allergen

Screenshot

Screenshot_20231107_171222

Related issue(s) and discussion

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 additives 🥜 Allergens labels Nov 7, 2023
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you add a comment at the top of the file to explain what anses_additives_of_interest is, and include a link to the source?

Thank you!

Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #9265 (2228e1c) into main (f344dcc) will increase coverage by 0.07%.
Report is 12 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9265      +/-   ##
==========================================
+ Coverage   47.88%   47.95%   +0.07%     
==========================================
  Files          65       65              
  Lines       20266    20277      +11     
  Branches     4916     4914       -2     
==========================================
+ Hits         9704     9724      +20     
+ Misses       9307     9301       -6     
+ Partials     1255     1252       -3     

see 5 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@alexgarel
Copy link
Member

@benbenben2 I think we can merge as you added the comment :-)

Really cool feature, I think @raphael0202 it goes in the same direction as the work on explaining additives.

@alexgarel alexgarel merged commit c42b62f into main Nov 9, 2023
13 checks passed
@alexgarel alexgarel deleted the anses_and_allergen branch November 9, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives 🥜 Allergens 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
4 participants