Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct handling of fractions without leading zero in Salt/Sodium content field Fixes #6717 #9337

Merged
merged 3 commits into from
Nov 29, 2023
Merged

fix: Correct handling of fractions without leading zero in Salt/Sodium content field Fixes #6717 #9337

merged 3 commits into from
Nov 29, 2023

Conversation

danwyk
Copy link
Collaborator

@danwyk danwyk commented Nov 18, 2023

What

Correct handling of fractions without leading zero in Salt/Sodium content field Fixes

Screenshot

image

Related issue(s) and discussion

@danwyk danwyk requested a review from a team as a code owner November 18, 2023 04:25
stephanegigandet
stephanegigandet approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e43774) 48.84% compared to head (259528d) 48.84%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9337   +/-   ##
=======================================
  Coverage   48.84%   48.84%           
=======================================
  Files          66       66           
  Lines       20380    20380           
  Branches     4891     4891           
=======================================
  Hits         9955     9955           
  Misses       9166     9166           
  Partials     1259     1259

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanegigandet stephanegigandet enabled auto-merge (squash) November 21, 2023 10:32
auto-merge was automatically disabled November 21, 2023 17:40

Head branch was pushed to by a user without write access

stephanegigandet
stephanegigandet approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@danwyk
Copy link
Collaborator Author

danwyk commented Nov 28, 2023

Looks good, thank you!

Thanks for getting me through the required test. I accidentally clicked "Update branch" when I saw my PR is behind the latest branch. And therefore it requires permission to run the required test again. Sorry about any inconvenience. Could you please grant me a permission again? Much obliged!

@stephanegigandet
Copy link
Contributor

@danwyk Sure. I also sent you an invite to join the team of the openfoodfacts-server repo so that it does not require approval to run tests.

@danwyk
Copy link
Collaborator Author

danwyk commented Nov 29, 2023

@danwyk Sure. I also sent you an invite to join the team of the openfoodfacts-server repo so that it does not require approval to run tests.

Really appreciate it! I've joined it. Thanks for inviting me.

@danwyk danwyk closed this Nov 29, 2023
@danwyk danwyk reopened this Nov 29, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 8aadd6c into openfoodfacts:main Nov 29, 2023
23 checks passed
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet Awaiting requested review from stephanegigandet

Assignees

@danwyk danwyk

Labels
JavaScript multilingual products
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editing Salt/Sodium content field does not work correctly with fractions without leading zero
3 participants
@danwyk @codecov-commenter @stephanegigandet