Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export obsolete products only once and include "obsolete" field in CSV export #10077

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

deveshidwivedi
Copy link
Contributor

What

  • This PR implements a fix to ensure that obsolete products are exported only once and do not appear as duplicates .
  • Introduces a new field "obsolete" in the CSV export.

Related issue(s) and discussion

scripts/export_database.pl Outdated Show resolved Hide resolved
scripts/export_database.pl Show resolved Hide resolved
scripts/export_database.pl Outdated Show resolved Hide resolved
scripts/export_database.pl Outdated Show resolved Hide resolved
@github-actions github-actions bot added 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org config labels Apr 4, 2024
@github-actions github-actions bot added the 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org label Apr 4, 2024
@github-actions github-actions bot added the 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org label Apr 4, 2024
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.59%. Comparing base (dc04d18) to head (aa13461).
Report is 220 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10077      +/-   ##
==========================================
+ Coverage   49.54%   49.59%   +0.05%     
==========================================
  Files          67       70       +3     
  Lines       20650    20967     +317     
  Branches     4980     5025      +45     
==========================================
+ Hits        10231    10399     +168     
- Misses       9131     9276     +145     
- Partials     1288     1292       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deveshidwivedi deveshidwivedi marked this pull request as ready for review April 6, 2024 06:09
@deveshidwivedi deveshidwivedi requested a review from a team as a code owner April 6, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config exports 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org
Projects
Development

Successfully merging this pull request may close these issues.

Obsolete products appear as duplicates in CSV export
3 participants