Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: romanian #10126

Merged
merged 3 commits into from Apr 17, 2024
Merged

taxonomy: romanian #10126

merged 3 commits into from Apr 17, 2024

Conversation

moon-rabbitOFF
Copy link
Contributor

What

Screenshot

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@moon-rabbitOFF moon-rabbitOFF requested a review from a team as a code owner April 14, 2024 16:52
@github-actions github-actions bot added 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients labels Apr 14, 2024
@benbenben2 benbenben2 changed the title romanian taxonomy: romanian Apr 16, 2024
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder:

Check if it is a phrase we want to ignore
NB: If these match, the whole ingredient is ignored, so they're not suitable for ignoring part of an ingredient.

This means that if "in proporţie variabilă" is not separated from the ingredient (example: walnut in variable proportion), it will ignore the whole sentence, including the ingredient (walnut in my example). It is fine if you in this language you always have for example "walnuts, in variable proportionm". Keep an eye on it in the future. If it appears to ignore ingredients (first described case) other option would be to add "in proporţie variabilă" in the stopword in the ingredients.txt file, instead.

As for the error, it is due to the formatting of the file (missing or too much spaces or indentations). It can be fixed by running "make lint" before to commit and push. I just did it.

@benbenben2 benbenben2 merged commit 359d9be into main Apr 17, 2024
12 checks passed
@benbenben2 benbenben2 deleted the moon-rabbitOFF-patch-5 branch April 17, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🇷🇴 Romania
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants