fix: disable the Invite Users button until at least one email address has been entered #10136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🏭 Producers Platform
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10136 +/- ##
==========================================
+ Coverage 49.54% 49.65% +0.10%
==========================================
Files 67 71 +4
Lines 20650 20978 +328
Branches 4980 5027 +47
==========================================
+ Hits 10231 10416 +185
- Misses 9131 9270 +139
- Partials 1288 1292 +4 ☔ View full report in Codecov by Sentry. |
alexgarel
reviewed
Apr 16, 2024
| <p>[% lang('enter_email_addresses_of_users') %]</p> | ||
| <textarea id="email_list" name="email_list" style="height:100px;width:50vw"></textarea> | ||
| <textarea id="email_list" name="email_list" style="height:100px;width:50vw" oninput="toggleInviteButton()"></textarea> |
There was a problem hiding this comment.
oninput does not exists in HTML ! Some JS framework provide it but they transform it to an event listener.
The way to do it is to use JQuery, something like:
$(document).ready(function () {
// observe email entry
$("#email_list").on("input", function(event) {
// handle event, eg. toggle Invite button
// you can get the textarea with event.target
});
});There was a problem hiding this comment.
Oh okay, I'll check this out. Thanks
|
alexgarel
approved these changes
Apr 19, 2024
john-gom
pushed a commit
that referenced
this pull request
May 24, 2024
… has been entered (#10136) * validate invite users button values * update validateEmail regex to address the concern of potential denial of service * handle event with jquery * fix sonarcloud integrity issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I added a script to the
templates/web/pages/org_form/org_form.tt.htmlfile that toggles off the Invite Users button until at least one email address has been entered.This script also uses Regex to validate the value of each email address entered to ensure users are inviting valid email addresses and not just random texts.
Fixes Disable Invite Users button on organisation page until email address is entered #10130