Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: configuration for OBF with new code + ProductsFeatures.pm for features by product type #10346

Merged
merged 11 commits into from
Jun 17, 2024
Merged

refactor: configuration for OBF with new code + ProductsFeatures.pm for features by product type #10346

merged 11 commits into from
Jun 17, 2024

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented May 24, 2024 •
edited
Loading

This PR contains:

  • configuration changes so that we can deploy the new product opener code for OBF, currently on the obf-new 116 container on off2. (See docs: install obf-new on off2 openfoodfacts-infrastructure#342 for a log of the install.)
  • a new way to activate features (e.g. ingredient list, nutrition data, Nutri-Score, NOVA, user preferences etc.) based on product type (and possibly later based on the actual product using its categories etc.), in a new ProductsFeatures.pm module

image

@stephanegigandet stephanegigandet requested a review from a team as a code owner May 24, 2024 14:59
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org NGINX labels May 24, 2024
@github-actions github-actions bot added 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org config labels May 27, 2024
@teolemon
Copy link
Member

Screenshot_20240527-210630.png

@github-actions github-actions bot added categories 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Display Lists of products multilingual products 🥗 Ingredients labels Jun 7, 2024
@stephanegigandet stephanegigandet changed the title chore: configuration for OBF with new code - WIP refactor: configuration for OBF with new code + ProductsFeatures.pm for features by product type Jun 7, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 13, 2024
@stephanegigandet stephanegigandet merged commit 92856e1 into main Jun 17, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the obf-new branch June 17, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4nt0ineB 4nt0ineB 4nt0ineB approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
categories config Display 🥗 Ingredients 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Lists of products multilingual products NGINX 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests
Projects
🐾 Open Pet Food Facts
Status: Done
📖 Knowledge panels
Status: Done
📸 Open Products Facts
Status: Done
🧴 Open Beauty Facts
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephanegigandet @teolemon @4nt0ineB