Optimize functions to display tags and add inline translation of taxonomies #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangy
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 parts for this pull request:
The way we have been computing the display name and the link of tags is very expensive: lots of function calls, and some functions are called twice. This has a huge performance toll for pages where we display lists of tags. This branch introduces a new get_taxonomy_tag_and_link_for_lang in Tags.pm that computes the necessary information only once.
Performance issue for pages that return a long list of tags #1630
in Display.pm, the display_list_of_tags function now uses that new get_taxonomy_tag_and_link_for_lang function, and there is a new function translate_list_of_tags for inline translation of taxonomies.
Allow inline translation of taxonomies on OFF web site #1721