-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a number of country defaults #2050
Conversation
Ecocert Canada -> Assumption is they would only certify canadian goods Bio Austria -> As above French brands -> Assuming they are products of France Champion beers -> assuming they are only open to beers produced in that country.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they need "country:en:" as the prefix.
We need to think carefully about what we exactly want to achieve here. We currently do not have a "country of origin" field (as in the product was made in that country). We could add one. Currently we use labels for that: "Made in Belgium". We have a "origins of ingredients" field where we put countries, but that's something else entirely. Also we should not make any assumptions without verifying them. It's very possible that Bio Austria etc. certify products that are imported. That does not mean they were produced in Austria. |
Happy to reduce it to just the "Made in XYZ" labels for now; others later |
I wasn't sure on that, as other examples didn't use that approach and it seemed more prevalent. Will swap those over however. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
Checklist:
Make sure you've done all the following (You can delete the checklist before submitting)
Description:
This adds a few country entries to specific labels.
Ecocert Canada -> Assumption is they would only certify canadian goods
Bio Austria -> As above
French brands -> Assuming they are products of France
Champion beers -> assuming they are only open to beers produced in that country.
Related issues and discussion: Closes openfoodfacts/openfoodfacts-ai#45