Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to Foundation 6.6 #2987

Closed
wants to merge 47 commits into from
Closed

Conversation

hangy
Copy link
Member

@hangy hangy commented Mar 7, 2020

I suggest that we upgrade from Foundation 5.5.x to Foundation 6.6.x. For now, this PR is a placeholder for the migration, which still requires some additional manual adjustments.

Part of

@hangy hangy added the foundation Foundation is the CSS framework of Open Food Facts. label Mar 7, 2020
@hangy hangy self-assigned this Mar 7, 2020
html/js/display-product.js Outdated Show resolved Hide resolved
@teolemon
Copy link
Member

Nice :-)
I was trying to use newer features of foundation, and I remembered this PR. Can't wait 👍

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet
Copy link
Contributor

Hi @hangy , I'm running into issues with Foundation 5.5. (I can't get dynamically created accordion to work).
Can you tell me what's missing in this PR? Maybe I can help finish it.

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hangy
Copy link
Member Author

hangy commented Oct 20, 2020

Can you tell me what's missing in this PR? Maybe I can help finish it.

I'm not sure what to use for the drilldown, since the original Foundation 5 component has disappeared: image

Also, the response layout looks a bit weird: image

Apart from that, I think it's mostly minor UI nitpicks, unless I missed major changes in master. I think the easiest way to see it yourself is to pull my farout branch and test it yourself. 🙂

@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon teolemon added the dependencies Pull requests that update a dependency file label Sep 16, 2021
@teolemon
Copy link
Member

@hangy : could you have a look if the rebase is doable ?
@alexgarel : if I remember well, we can do a deploy branch to push that to .net ?

@teolemon teolemon added the CSS label Jan 20, 2022
@hangy
Copy link
Member Author

hangy commented Jan 20, 2022

@hangy : could you have a look if the rebase is doable ?
@alexgarel : if I remember well, we can do a deploy branch to push that to .net ?

I don't think so. The PR probably needs to be restarted - at least when it comes to the HTML, there are a lot of changes, because the content was moved to template::toolkit after I started it.

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Feb 18, 2022
@teolemon teolemon changed the title Upgrade to Foundation 6.6 feat: Upgrade to Foundation 6.6 Feb 27, 2022
@hangy hangy closed this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS dependencies Pull requests that update a dependency file foundation Foundation is the CSS framework of Open Food Facts. 💥 Merge Conflicts 💥 Merge Conflicts
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants