feat: Show barcode image on product page - Fixes #1728 #4227
Conversation
`Show barcode image on product page` * Added JsBarcode CDN link to the frontend. * Now the `barcode number` is converted to a vector image.
…aragraph) * Fixed dangling svg issue (It occured when the javascript was turned off)
|
Can someone review it ? |
| const barcode = document.getElementById('barcode'); | ||
|
|
||
| // Get the barcode_paragraph `p` element from DOM. | ||
| const barcodeParagraph = document.getElementById('barcode_paragraph'); |
There was a problem hiding this comment.
The barcode_paragraph element does not exist, if the barcode doesn't start with a 0, so that should likely be checked before doing all of this. Maybe even the JsBarcode.all.min.js script only needs to be included, if we know the barcode will be replaced by an SVG.
There was a problem hiding this comment.
Also, it may need to be limited to some page types, because right now, the barcode is also replaced if I still have to log in: 
There was a problem hiding this comment.
Can you mention the pages, on which the barcode is needed
There was a problem hiding this comment.
@stephanegigandet @teolemon Where did you initially want the barcode to be displayed?
There was a problem hiding this comment.
Hi @ArishSultan, sorry for my late reply. We should show the barcode only the product info page: https://world.openfoodfacts.org/product/5022019160310/organic-ginger-beer-belvoir
Ideally it would appear when we click on a barcode button.
|
Kudos, SonarCloud Quality Gate passed!
|
teolemon
changed the title
teolemon
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
Did @ArishSultan 's latest commit fix your concerns about the display only on the product page ? |
teolemon
changed the title
What
barcode numberis converted to a vector image.Related issues and discussion
Screenshot
Part of