Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very small start of a refactoring for handling links of texts translations #5263

Merged
merged 2 commits into from
May 31, 2021

Conversation

stephanegigandet
Copy link
Contributor

This is to solve the issue of texts that have different urls in different languages, and how we can link to them easily. (see #1818)

This is just a start. It solves #5260, but with an hardcoded mapping structure.

The goal is to generate the mapping structure at startup, using the available translations in the texts directory (we could create a new one, and move texts gradually).

@stephanegigandet stephanegigandet added the 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products label May 27, 2021
@stephanegigandet stephanegigandet requested review from a team, roshnaeem and hangy May 27, 2021 15:22
@sonarcloud
Copy link

sonarcloud bot commented May 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet stephanegigandet merged commit b144440 into main May 31, 2021
@stephanegigandet stephanegigandet deleted the ecoscore branch May 31, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants