Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons from the French CITEO national recycling system (dark and light mode) #5627

Merged
merged 2 commits into from Sep 8, 2021

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Sep 7, 2021

What

  • Icons from the CITEO national recycling system (dark and light mode)
  • Mapping to the packaging shapes will be done by a separate file, so that we can keep the granularity of the shapes (there are several icons for a same shape name)
  • Attribution © French CITEO national recycling system is necessary

image

Required by

icons from the CITEO national recycling system (dark and light mode)
@teolemon teolemon added the 📦 Packaging shapes https://github.com/openfoodfacts/openfoodfacts-server/blob/main/taxonomies/packaging_shapes.txt label Sep 7, 2021
@teolemon teolemon requested a review from a team as a code owner September 7, 2021 12:25
@teolemon teolemon added ✏️ Editing 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels labels Sep 7, 2021
@stephanegigandet
Copy link
Contributor

We should add a README and LICENCE files to acknowledge the source (ideally with a link to it) and warn that those icons are the property of CITEO. We probably need similar files as well for labels logos too.

Where do the files come from? Straight from CITEO, or there was some processing applied to them, or to their file path / file names?

@teolemon
Copy link
Member Author

teolemon commented Sep 7, 2021

@stephanegigandet done. I used the PDF mentioned in the README, but CITEO also has a large Adobe Illustrator file (also mentioned).
I created the dark icons with recoloring. It would be nice for the knowledge panel API to support dark mode.

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon merged commit 2ee80a3 into main Sep 8, 2021
@teolemon teolemon deleted the citeo-shapes branch September 8, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 📦 Packaging shapes https://github.com/openfoodfacts/openfoodfacts-server/blob/main/taxonomies/packaging_shapes.txt
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants