Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize code for /products endpoint #6024 #6026

Merged
merged 1 commit into from
Oct 27, 2021
Merged

fix: normalize code for /products endpoint #6024 #6026

merged 1 commit into from
Oct 27, 2021

Conversation

stephanegigandet
Copy link
Contributor

fixes #6024

Calls normalization of product barcodes passed through the /products endpoint

to test on .dev server:

https://fr.openfoodfacts.dev/products/03017620422003,3019082000362.json?fields=code

@stephanegigandet stephanegigandet added the API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) label Oct 26, 2021
@stephanegigandet stephanegigandet requested a review from a team as a code owner October 26, 2021 14:06
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

blazern
blazern approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@blazern blazern left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Perl and couldn't understand much of what is changed, sorry :(
Maybe I should start reading something about the language :)

@stephanegigandet stephanegigandet requested a review from a team October 26, 2021 14:42
@blazern
Copy link
Contributor

blazern commented Oct 27, 2021

Is it safe to merge now? :)

@stephanegigandet stephanegigandet merged commit 640f6b5 into main Oct 27, 2021
@stephanegigandet stephanegigandet deleted the fix-products-endpoint branch October 27, 2021 09:06
hangy pushed a commit to hangy/openfoodfacts-server that referenced this pull request Oct 27, 2021
@pull @stephanegigandet
fix: normalize code for /products endpoint openfoodfacts#6024 (openfo…
3cafb22 
…odfacts#6026) (#1234)

Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
@github-actions github-actions bot mentioned this pull request Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blazern blazern blazern approved these changes

@jasmeet0817 jasmeet0817 jasmeet0817 approved these changes

Assignees
No one assigned
Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The 'products' endpoint doesn't fix invalid barcodes
3 participants
@stephanegigandet @blazern @jasmeet0817