Recommendation panels (global + country specific) for health: alcohol and pulses #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📖 Knowledge Panels
alexgarel
approved these changes
Jan 11, 2022
| }, | ||
| [% END %] | ||
| ] | ||
| } |
There was a problem hiding this comment.
C'est normal qu'il soit là lui ?
templates/web/panels/panel.tt.html
Outdated
| @@ -149,6 +149,17 @@ <h4 class="panel_title"> | |||
| <img src="[% image_element.url %]" alt="[% image_element.alt %]"> | |||
| [% IF image_element.link_url.defined %]</a>[% END %] | |||
|
|
|||
| [% IF image_element.source_url.defined %] | |||
| <div class="image_source" style="font-style:italic">[% lang("source") %][% sep %]: | |||
| <a href="[% text_element.source_url %]">[% image_element.source_text %] | |||
There was a problem hiding this comment.
isn't it href="[% image_element.source_url %]" ? or is it the IF above ill defined ? I'm a bit confused…
There was a problem hiding this comment.
ah right, my mistake, thanks!
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first implementation of panels to make recommendations based on products (e.g. categories, ingredients, nutrients) and users (based on country, language, and maybe later on personal preferences).
The first recommendations are examples, to see how it looks on the web and in the app, experiment with ways to define them etc.
Those first recommendations are related to health and shown in the health card, below the Nutri-Score panel, but we could also have other kinds of recommendations, for instance related to the environment.
The first recommendation is for alcoholic beverages. By default, we show the WHO recommendation, and for users in France with the French language, we show instead the recommendation from the French health agency.
in France:
The second one is to suggest eating more pulses, and this one is specific to France.
Note: there should be an extra link in the panel to indicate the source of the recommendation, but the implementation is in another PR: #6270