Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dutch next round #6556

Merged
merged 15 commits into from
Apr 8, 2022
Merged

fix: Dutch next round #6556

merged 15 commits into from
Apr 8, 2022

Conversation

aleene
Copy link
Contributor

@aleene aleene commented Apr 5, 2022

Went through the new additions and improved the taxonomies accordingly.

@aleene aleene self-assigned this Apr 5, 2022
@github-actions github-actions bot added 🧪 additives categories 🥗 Ingredients labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Apr 5, 2022
@aleene aleene changed the title Dutch next round fix:Dutch next round Apr 5, 2022
@teolemon teolemon added this to the 1.1.1 milestone Apr 5, 2022
@aleene aleene changed the title fix:Dutch next round fix: Dutch next round Apr 5, 2022
@stephanegigandet
Copy link
Contributor

ERROR - nl:duurzame-visserij already is associated to en:sustainable-fishing-method - nl:duurzame-visserij cannot be mapped to entry en:sustainable-fishing

-> this one is subtle: we want to differentiate "Sustainable fishing" (which contains anything related to sustainable fishing, like the MSC label), from "Sustainable fishing methods".

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@alexgarel alexgarel merged commit df5d391 into main Apr 8, 2022
@alexgarel alexgarel deleted the aleene-dutch-again branch April 8, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants