Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ingredients and nutrition should have titles #6839

Merged
merged 5 commits into from
Jun 2, 2022
Merged

fix: ingredients and nutrition should have titles #6839

merged 5 commits into from
Jun 2, 2022

Conversation

alexgarel
Copy link
Member

because we made them collapsible.

fixes: #6835

@alexgarel
fix: ingredients and nutrition should have titles
9dde734 
because we made them collapsable.

fixes: #6835
@alexgarel alexgarel requested a review from a team as a code owner May 31, 2022 14:16
@github-actions github-actions bot added 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels May 31, 2022
stephanegigandet
stephanegigandet reviewed May 31, 2022
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
@alexgarel
Copy link
Member Author

I get icons from : https://icon-sets.iconify.design/fa-solid/balance-scale-left/ and https://icon-sets.iconify.design/mdi/bowl-mix/
So I think it's okay for copyright… but not 100% sure !

stephanegigandet
stephanegigandet reviewed May 31, 2022
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
stephanegigandet
stephanegigandet approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can merge as-is, and then maybe later we can try to make things a bit better when we don't know the ingredients.

@stephanegigandet
Copy link
Contributor

I get icons from : https://icon-sets.iconify.design/fa-solid/balance-scale-left/ and https://icon-sets.iconify.design/mdi/bowl-mix/ So I think it's okay for copyright… but not 100% sure !

Ah, I forgot one thing about icons: we should add them to the /icons directory instead of creating a separate directory for panel icons.

@github-actions github-actions bot added the icons label Jun 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexgarel alexgarel merged commit 8048013 into main Jun 2, 2022
@alexgarel alexgarel deleted the fix-large-kp-titles branch June 2, 2022 09:39
@alexgarel alexgarel mentioned this pull request Jun 2, 2022
Merged
@stephanegigandet stephanegigandet mentioned this pull request Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@alexgarel alexgarel

Labels
icons 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
Product Opener - Sprint
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add title to ingredients panel and nutrition facts table panel
2 participants
@alexgarel @stephanegigandet