Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Taxonomy change requests week 40 #7440

Merged
merged 9 commits into from
Oct 12, 2022
Merged

chore: Taxonomy change requests week 40 #7440

merged 9 commits into from
Oct 12, 2022

Conversation

aleene
Copy link
Contributor

@aleene aleene commented Oct 4, 2022

What

The taxonomy change requests that have been submitted in week 40 on Slack and elsewhere

@aleene aleene requested a review from a team as a code owner October 4, 2022 17:00
@aleene aleene self-assigned this Oct 4, 2022
@github-actions github-actions bot added labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Oct 4, 2022
@aleene
@manon Corneille rquest
bdfd394 
synonym for feve
@aleene aleene marked this pull request as draft October 4, 2022 17:04
@aleene aleene changed the title Taxonomy change requests week 40 chore: Taxonomy change requests week 40 Oct 4, 2022
stephanegigandet
stephanegigandet approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but:

the image:en: property is not used

currently we only display logos with an height of 90px.

@aleene
Copy link
Contributor Author

aleene commented Oct 6, 2022

@stephanegigandet Can we define a process to add images and link them with a taxonomy?

@stephanegigandet
Copy link
Contributor

@stephanegigandet Can we define a process to add images and link them with a taxonomy?

@aleene I filed #7447

@aleene aleene marked this pull request as ready for review October 11, 2022 15:17
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aleene aleene merged commit 502086e into main Oct 12, 2022
@aleene aleene deleted the aleene-requests-week-40 branch October 12, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@aleene aleene

Labels
🥗 Ingredients labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aleene @stephanegigandet