Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responsive product list css #7928

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix: responsive product list css #7928

merged 1 commit into from
Jan 5, 2023

Conversation

stephanegigandet
Copy link
Contributor

Related to #7499
Continuation of #7916

This removes CSS code that was duplicated between _off.scss and _product-list.scss

It removes some special behaviour from the old design: on small screen, we had only 1 product card per line, but now we have 2.

When we have multiple cards per line (which is now always the case), we fix some heights so that the attribute icons are vertically aligned on the different product cards.

image

@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on this !

@alexgarel alexgarel merged commit b7e8912 into main Jan 5, 2023
@alexgarel alexgarel deleted the product-list-scss branch January 5, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants