Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Packagings display improvements on product page #7938

Merged
merged 3 commits into from
Jan 4, 2023
Merged

fix: Packagings display improvements on product page #7938

merged 3 commits into from
Jan 4, 2023

Conversation

stephanegigandet
Copy link
Contributor

Changes to the product display page:

image
(i selected a random part of the image, imagine it's a packaging image :) )

@stephanegigandet stephanegigandet requested a review from a team as a code owner January 4, 2023 11:14
@github-actions github-actions bot added 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Jan 4, 2023
@stephanegigandet stephanegigandet changed the title Packagings display fix: Packagings display improvements on product page Jan 4, 2023
teolemon
teolemon approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double whoohoo

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet stephanegigandet merged commit 7bab391 into main Jan 4, 2023
@stephanegigandet stephanegigandet deleted the packagings-display branch January 4, 2023 13:49
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
2 participants
@stephanegigandet @teolemon