Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unsaturated fat support #8064

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Conversation

aleene
Copy link
Contributor

@aleene aleene commented Feb 3, 2023

What

Added unsaturated fat to support dutch products

Related issue(s) and discussion

Maybe it is useful to create a section for products sold in the Netherlands?

However there should be a world version that contains everything.

Could be move this data to nutrients.txt?

@aleene aleene requested a review from a team as a code owner February 3, 2023 09:24
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@dab7ac3). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8064   +/-   ##
=======================================
  Coverage        ?   44.70%           
=======================================
  Files           ?      100           
  Lines           ?    20212           
  Branches        ?     4636           
=======================================
  Hits            ?     9035           
  Misses          ?    10103           
  Partials        ?     1074           
Impacted Files Coverage Δ
lib/ProductOpener/Food.pm 61.30% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@alexgarel alexgarel changed the title unsaturated fat support feat: unsaturated fat support for dutch Feb 3, 2023
@alexgarel alexgarel changed the title feat: unsaturated fat support for dutch feat: unsaturated fat support Feb 3, 2023
@alexgarel
Copy link
Member

@aleene: don't forget to run "make lint_perltidy" to avoid failing on checks because of perltidy.

@alexgarel
Copy link
Member

I pushed a commit, it should be ok.

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 0f9e2d9 into main Feb 3, 2023
@stephanegigandet stephanegigandet deleted the aleene-onverzadigde-vetten branch February 3, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants