Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve OpenAPI documentation about images #8341

Merged
merged 2 commits into from
Apr 21, 2023
Merged

docs: improve OpenAPI documentation about images #8341

merged 2 commits into from
Apr 21, 2023

Conversation

raphael0202
Copy link
Contributor

@raphael0202 raphael0202 commented Apr 21, 2023 •
edited by teolemon
Loading

What

  • Improve OpenAPI documentation about image selection/upload.

Part of

@raphael0202 raphael0202 requested a review from a team as a code owner April 21, 2023 04:42
@github-actions github-actions bot added API WRITE WRITE API to allow sending product info and image 📚 Documentation Documentation issues improve the project for everyone. labels Apr 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023 •
edited
Loading

Codecov Report

Merging #8341 (381e5a9) into main (187098b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8341   +/-   ##
=======================================
  Coverage   48.16%   48.16%           
=======================================
  Files         109      109           
  Lines       21015    21015           
  Branches     4739     4739           
=======================================
  Hits        10122    10122           
  Misses       9618     9618           
  Partials     1275     1275

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

stephanegigandet
stephanegigandet approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @raphael0202 , I added a minor suggestion.

@teolemon teolemon added the OpenAPI OpenAPI documentation of Open Food Facts. Still incomplete, and needs help. label Apr 21, 2023
@alexgarel @stephanegigandet
Update docs/api/ref/requestBodies/crop_a_photo.yaml
381e5a9 
Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@raphael0202 raphael0202 merged commit 4a2e7fc into main Apr 21, 2023
@raphael0202 raphael0202 deleted the improve-api-v2 branch April 21, 2023 09:52
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@raphael0202 raphael0202

Labels
API WRITE WRITE API to allow sending product info and image 📚 Documentation Documentation issues improve the project for everyone. OpenAPI OpenAPI documentation of Open Food Facts. Still incomplete, and needs help.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@raphael0202 @codecov-commenter @stephanegigandet @teolemon @alexgarel