Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migration of Open Food Facts from off1 (bare metal) to off2 (proxmox) #8827

Merged
merged 140 commits into from
Nov 23, 2023

Conversation

alexgarel
Copy link
Member

@alexgarel alexgarel commented Aug 9, 2023

What

  • Migration of Open Food Facts (site and pro platform) from off1 (bare metal) to off2 (proxmox)
  • Modifications linked to moving off and off-pro to off2 server.
  • This includes a lot of path modifications:
    • some directories where removed from the repository and are created dynamically
    • we try to differentiate folders containing code (only this is in git), data, cache data and dist files
    • we control this by using a fixed set of base path (see Paths.pm)
  • Most of server configurations are now in the git repository
  • Import scripts where reworked

See also: openfoodfacts/openfoodfacts-infrastructure#243

Part of

@github-actions github-actions bot added NGINX 🐋 Docker https://docker-curriculum.com/ labels Aug 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Attention: 161 lines in your changes are missing coverage. Please review.

Comparison is base (0234c56) 48.68% compared to head (503cbc4) 48.81%.
Report is 1 commits behind head on main.

Files Patch % Lines
lib/ProductOpener/Display.pm 3.57% 27 Missing ⚠️
lib/ProductOpener/Images.pm 43.33% 15 Missing and 2 partials ⚠️
lib/ProductOpener/Users.pm 10.52% 17 Missing ⚠️
lib/ProductOpener/Paths.pm 74.57% 14 Missing and 1 partial ⚠️
lib/ProductOpener/Products.pm 17.64% 14 Missing ⚠️
lib/ProductOpener/Producers.pm 20.00% 12 Missing ⚠️
lib/ProductOpener/Tags.pm 20.00% 12 Missing ⚠️
lib/ProductOpener/Missions.pm 11.11% 8 Missing ⚠️
lib/ProductOpener/PackagingStats.pm 12.50% 7 Missing ⚠️
lib/ProductOpener/Attributes.pm 88.23% 4 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8827      +/-   ##
==========================================
+ Coverage   48.68%   48.81%   +0.13%     
==========================================
  Files          65       66       +1     
  Lines       20268    20355      +87     
  Branches     4896     4883      -13     
==========================================
+ Hits         9867     9937      +70     
- Misses       9141     9161      +20     
+ Partials     1260     1257       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added 👥 Users OCR export 🗺️ Made Near Me MongoDB We have 2 mongodb collections: one for current products, and one for obsolete products 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling averages by categories Generating & Leveraging average nutrition values by category Data import 🕹️ Gamification 🖼️ Images 🧪 tests 🪶 Apache We use Apache as a server to run Open Food Facts 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Recent changes Implemented by @hangy - https://world.openfoodfacts.org/cgi/recent_changes.pl?&page=1&page_size=25 Food.pm Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org moderation 🍬 How much sugar https://howmuchsugar.in/ - Mini game powered by Open Food Facts data GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. Display Products Tags lang Orgs labels Aug 11, 2023
@github-actions github-actions bot removed 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org dependencies Pull requests that update a dependency file Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Numbers ingredients ingredients analysis 🚦 Nutri-Score Allergens Ingredients processing labels Nov 21, 2023
@github-actions github-actions bot added Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products Attributes https://wiki.openfoodfacts.org/Product_Attributes 🚦 Nutri-Score labels Nov 22, 2023
@github-actions github-actions bot added the API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) label Nov 22, 2023
Copy link

sonarcloud bot commented Nov 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 24 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@alexgarel alexgarel merged commit 41b5ad8 into main Nov 23, 2023
14 of 15 checks passed
@alexgarel alexgarel deleted the off-off2-migration branch November 23, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives 🏭 AGENA3000 🪶 Apache We use Apache as a server to run Open Food Facts API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Attributes https://wiki.openfoodfacts.org/Product_Attributes averages by categories Generating & Leveraging average nutrition values by category categories config Data import 🧽 Data quality https://wiki.openfoodfacts.org/Quality Display 🐋 Docker https://docker-curriculum.com/ 📚 Documentation Documentation issues improve the project for everyone. 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🏭 EQUADIS export exports file import Food.pm 🕹️ Gamification GitHub Actions Pull requests that update Github_actions code GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. 🍬 How much sugar https://howmuchsugar.in/ - Mini game powered by Open Food Facts data images infrastructure 🧪 integration tests JavaScript 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels labels lang 🗺️ Made Near Me 📨 Mail MainCountries 💥 Merge Conflicts 💥 Merge Conflicts Minion 👮 Moderation MongoDB We have 2 mongodb collections: one for current products, and one for obsolete products multilingual products NGINX Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova 🚦 Nutri-Score OCR 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org 🏭 Orgs 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🔐 Password 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Products Recent changes Implemented by @hangy - https://world.openfoodfacts.org/cgi/recent_changes.pl?&page=1&page_size=25 Scanbot store Tags Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 🧪 unit tests update all products URL 👥 Users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet