feat: donation banner 2024 integration #9422
Conversation
github-actions
bot
added
CSS
Template::Toolkit
po/common/common.pot
Outdated
| msgstr "" | ||
|
|
||
| msgctxt "donation_text_2023_tertiary" | ||
| msgid "The food revolution starts with you !" |
There was a problem hiding this comment.
There's no space before ! in English
| msgid "The food revolution starts with you !" | |
| msgid "The food revolution starts with you!" |
| <p class="donation-banner__secondary-text">[% lang("donation_text_2023_secondary") %]</p> | ||
| <p class="donation-banner__tertiary-text">[% lang("donation_text_2023_tertiary") %]</p> | ||
| </div> | ||
| <a class="donation-banner__donate" href="https://fr.openfoodfacts.org/faire-un-don-a-open-food-facts?utm_source=off&utf_medium=web&utm_campaign=donate-2023-a&utm_term=en-text-button">Donate</a> |
There was a problem hiding this comment.
We should use [% link %] in there I think, we can't hardcode the fr address
|
Is half-logo.svg slightly rotated on purpose? |
|
there is no rotation on half-logo.svg. |
|
@stephanegigandet I think it's all good for the pull request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9422 +/- ##
==========================================
- Coverage 48.85% 48.84% -0.01%
==========================================
Files 66 66
Lines 20376 20380 +4
Branches 4889 4891 +2
==========================================
Hits 9955 9955
- Misses 9162 9166 +4
Partials 1259 1259 ☔ View full report in Codecov by Sentry. |
| <p class="donation-banner__secondary-text">[% lang("donation_text_2023_secondary") %]</p> | ||
| <p class="donation-banner__tertiary-text">[% lang("donation_text_2023_tertiary") %]</p> | ||
| </div> | ||
| <a class="donation-banner__donate" href="[% link %]?utm_source=off&utf_medium=web&utm_campaign=donate-2023-a&utm_term=en-text-button">Donate</a> |
There was a problem hiding this comment.
"Donate" should be a translatable string
| <p class="donation-banner-footer__secondary-text">[% lang("donation_text_2023_secondary") %]</p> | ||
| <p class="donation-banner-footer__tertiary-text">[% lang("donation_text_2023_tertiary") %]</p> | ||
| </div> | ||
| <a class="donation-banner-footer__donate" href="https://fr.openfoodfacts.org/faire-un-don-a-open-food-facts?utm_source=off&utf_medium=web&utm_campaign=donate-2023-a&utm_term=en-text-button">Donate</a> |
There was a problem hiding this comment.
There's still an hardcoded link, + a "Donate" string
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos @Valimp :-) |
What
Integration of the new donation banner for 2024
Screenshot
Related issue(s) and discussion
@stephanegigandet @raphael0202