Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dq saturated fat only if fat defined #9463

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

benbenben2
Copy link
Collaborator

What

rework error for saturated fat greater than fat to be triggered only if fat is defined

Related issue(s) and discussion

@benbenben2 benbenben2 added 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data 🧽 Data quality - Nutrition labels Dec 1, 2023
@benbenben2 benbenben2 self-assigned this Dec 1, 2023
@benbenben2 benbenben2 requested a review from a team as a code owner December 1, 2023 22:19
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be477d2) 49.00% compared to head (52bd14f) 49.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9463   +/-   ##
=======================================
  Coverage   49.00%   49.01%           
=======================================
  Files          66       66           
  Lines       20421    20421           
  Branches     4904     4904           
=======================================
+ Hits        10008    10009    +1     
+ Misses       9144     9143    -1     
  Partials     1269     1269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit 2a668c1 into main Dec 5, 2023
14 checks passed
@stephanegigandet stephanegigandet deleted the dq_saturated_fat_only_if_fat_defined branch December 5, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data 🧽 Data quality - Nutrition 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saturate fat errror inadvertently triggered
3 participants