Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Category translations #9673

Merged
merged 7 commits into from
Feb 5, 2024
Merged

taxonomy: Category translations #9673

merged 7 commits into from
Feb 5, 2024

Conversation

teolemon
Copy link
Member

What

taxonomy: Category translations

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Jan 19, 2024
@teolemon
Copy link
Member Author

ERROR - nl:yoghurts-met-fruit-en-suiker already is associated to en:yogurt-with-fruits-and-sugar (categories) - nl:yoghurts-met-fruit-en-suiker cannot be mapped to entry en:yogurts-with-fruits-and-sugar
ERROR - fi:kanavoileivät already is associated to en:poultry-sandwiches (categories) - fi:kanavoileivät cannot be mapped to entry en:chicken-sandwiches

@alexgarel
Copy link
Member

@teolemon

Errors in the categories taxonomy definition:
ERROR - nl:yoghurts-met-fruit-en-suiker already is associated to en:yogurt-with-fruits-and-sugar (categories) - nl:yoghurts-met-fruit-en-suiker cannot be mapped to entry en:yogurts-with-fruits-and-sugar
ERROR - fi:kanavoileivät already is associated to en:poultry-sandwiches (categories) - fi:kanavoileivät cannot be mapped to entry en:chicken-sandwiches

@teolemon
Copy link
Member Author

yes, I commented that 2hours ago ;-)

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (acf96bb) 44.17% compared to head (3a069ae) 49.54%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9673      +/-   ##
==========================================
+ Coverage   44.17%   49.54%   +5.36%     
==========================================
  Files          65       67       +2     
  Lines       20557    20650      +93     
  Branches     4966     4980      +14     
==========================================
+ Hits         9082    10231    +1149     
+ Misses      10294     9131    -1163     
- Partials     1181     1288     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon marked this pull request as ready for review January 27, 2024 13:05
Comment on lines 88975 to 88982
nl:Gevogelte sandwiches
es:Bocadillos de aves
it:Panini di carne avicola
pt:Sanduíches de aves
bg:Сандвичи с птици
es:Sándwiches de aves
it:Panini al pollame
nl:Pluimvee sandwiches
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nl:Gevogelte sandwiches
es:Bocadillos de aves
it:Panini di carne avicola
pt:Sanduíches de aves
bg:Сандвичи с птици
es:Sándwiches de aves
it:Panini al pollame
nl:Pluimvee sandwiches
nl:Gevogelte sandwiches, pluimvee sandwiches
es:Bocadillos de aves
it:Panini di carne avicola
pt:Sanduíches de aves
bg:Сандвичи с птици
es:Sándwiches de aves
it:Panini al pollame

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

found synonyms. See suggestion

@teolemon
Copy link
Member Author

ERROR - nl:dolce-gusto-compatibele-koffiecapsules already is associated to en:dolce-gusto-compatible-coffee-capsules (categories) - nl:dolce-gusto-compatibele-koffiecapsules cannot be mapped to entry en:dolce-gusto-compatible-capsules
ERROR - pt:capsulas-de-cafe-compativeis-com-dolce-gusto already is associated to en:dolce-gusto-compatible-coffee-capsules (categories) - pt:capsulas-de-cafe-compativeis-com-dolce-gusto cannot be mapped to entry en:dolce-gusto-compatible-capsules

@teolemon
Copy link
Member Author

@benbenben2 I did a substantial commit from another branch on my laptop after your review. Could you have a look at that commit ?
622824a

If everything still ok, please tell me so and I merge.

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment about English translation.

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@teolemon teolemon merged commit 36f884a into main Feb 5, 2024
12 checks passed
@teolemon teolemon deleted the categories-19-01-2024 branch February 5, 2024 19:14
john-gom pushed a commit that referenced this pull request May 24, 2024
* Update categories.txt

* Update categories.txt

* Update categories.txt

* Update categories.txt

* Update categories.txt

* Update categories.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants