Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: large update on diary products #9855

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

OpenChris
Copy link
Contributor

Large update on Cheeses, Diary products

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Mar 1, 2024
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thank you @OpenChris !

@@ -43104,6 +43108,8 @@ wikidata:en:Q5761746
<en:Brined cheeses
<en:String cheeses
en:Chechil
tr:cecil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, in the future, try to order in alphabetical order (english first and then alphabetical order).

Not a big deal, no need to change now, there is a script to reorder them.

@@ -43900,6 +43906,14 @@ protected_name_type:en: pdo
origins:en: en:Austria
wikidata:en:Q688683

<en:Austrian cheeses
<en:Cow cheeses
au:quargel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future, try to start by English translation

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 89a7763 into main Mar 6, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the openchris-taxonomies branch March 6, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants