-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep only one (or two?) mongodb export #9946
Conversation
Quality Gate passedIssues Measures |
See also #9946 We will need to update the documentation to remove references to the removed dumps. |
Should we put up a deprecation notice for a month or so before removing this export? |
We could, but I'm not sure where we could put that deprecation notice for it to have a chance to be read by people who may have automated the download of the export. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok. We had both for about one year so I think we can move on !
@stephanegigandet before merging, maybe, amend the data page + be sure to remove the old archive in production (better have a 404 than serving an old archive forever). |
@alexg : "before merging, maybe, amend the data page + be sure to remove the old archive in production (better have a 404 than serving an old archive forever)." Date page update PR: openfoodfacts/openfoodfacts-web#563 I'll remove the old archive when this is deployed. |
We currently generate 3 MongoDB exports, each of them takes more than one hour to generate every day:
I suggest that we completely remove openfoodfacts-mongodbdump.tar.gz which has exactly the same usage as openfoodfacts-mongodbdump.gz
I'm not sure if we should keep the jsonl. As I recall, it was added for Robotoff. Do we still need it? Or do we still want to provide it to others, so that's it's possible to get JSON data without having MongoDB?