fix: #2841 - from "AddNewProductPage", no need to be logged in to add…

… data (#2844) * fix: #2841 - from "AddNewProductPage", no need to be logged in to add data Impacted files: * `add_basic_details_page.dart`: added parameter `bool isLoggedInMandatory` * `add_new_product_page.dart`: explicitly calls both pages `AddBasicDetailsPage` and `NutritionPageLoaded` with `isLoggedInMandatory: false` * `nutrition_page_loaded.dart`: added parameter `bool isLoggedInMandatory` * Update presubmit.yml Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
openfoodfacts · Aug 26, 2022 · 474b3d8 · 474b3d8
1 parent 45764d9
commit 474b3d8
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 7 deletions.
diff --git a/.github/workflows/presubmit.yml b/.github/workflows/presubmit.yml
@@ -1,9 +1,7 @@
 name: SmoothApp Pre-Submit Tests
 
 on:
-  push:
-    branches-ignore:
-      - develop
+  pull_request
 
 
 env:
@@ -51,4 +49,4 @@ jobs:
       - name: Upload coverage to codecov
         uses: codecov/codecov-action@v3
         with:
-          fail_ci_if_error: false
+          fail_ci_if_error: false
diff --git a/packages/smooth_app/lib/pages/product/add_basic_details_page.dart b/packages/smooth_app/lib/pages/product/add_basic_details_page.dart
@@ -11,9 +11,13 @@ import 'package:smooth_app/pages/product/common/product_refresher.dart';
 import 'package:smooth_app/widgets/smooth_scaffold.dart';
 
 class AddBasicDetailsPage extends StatefulWidget {
-  const AddBasicDetailsPage(this.product);
+  const AddBasicDetailsPage(
+    this.product, {
+    this.isLoggedInMandatory = true,
+  });
 
   final Product product;
+  final bool isLoggedInMandatory;
 
   @override
   State<AddBasicDetailsPage> createState() => _AddBasicDetailsPageState();
@@ -135,6 +139,7 @@ class _AddBasicDetailsPageState extends State<AddBasicDetailsPage> {
                         brands: _brandNameController.text,
                         barcode: _product.barcode,
                       ),
+                      isLoggedInMandatory: widget.isLoggedInMandatory,
                     );
                     if (!savedAndRefreshed) {
                       return;

diff --git a/packages/smooth_app/lib/pages/product/add_new_product_page.dart b/packages/smooth_app/lib/pages/product/add_new_product_page.dart
@@ -277,6 +277,7 @@ class _AddNewProductPageState extends State<AddNewProductPage> {
               builder: (BuildContext context) => NutritionPageLoaded(
                 Product(barcode: widget.barcode),
                 cache.orderedNutrients,
+                isLoggedInMandatory: false,
               ),
               fullscreenDialog: true,
             ),
@@ -329,6 +330,7 @@ class _AddNewProductPageState extends State<AddNewProductPage> {
             MaterialPageRoute<Product>(
               builder: (BuildContext context) => AddBasicDetailsPage(
                 Product(barcode: widget.barcode),
+                isLoggedInMandatory: false,
               ),
             ),
           );

diff --git a/packages/smooth_app/lib/pages/product/nutrition_page_loaded.dart b/packages/smooth_app/lib/pages/product/nutrition_page_loaded.dart
@@ -22,11 +22,13 @@ import 'package:smooth_app/widgets/smooth_scaffold.dart';
 class NutritionPageLoaded extends StatefulWidget {
   const NutritionPageLoaded(
     this.product,
-    this.orderedNutrients,
-  );
+    this.orderedNutrients, {
+    this.isLoggedInMandatory = true,
+  });
 
   final Product product;
   final OrderedNutrients orderedNutrients;
+  final bool isLoggedInMandatory;
 
   @override
   State<NutritionPageLoaded> createState() => _NutritionPageLoadedState();
@@ -528,6 +530,7 @@ class _NutritionPageLoadedState extends State<NutritionPageLoaded> {
       context: context,
       localDatabase: localDatabase,
       product: changedProduct,
+      isLoggedInMandatory: widget.isLoggedInMandatory,
     );
   }
 }