Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indicator that photo is being processed after cropping #1243

Closed
Tracked by #513
alexgarel opened this issue Mar 17, 2022 · 5 comments
Closed
Tracked by #513

No indicator that photo is being processed after cropping #1243

alexgarel opened this issue Mar 17, 2022 · 5 comments
Assignees

Comments

@alexgarel
Copy link
Member

alexgarel commented Mar 17, 2022

What

  • When you add a photo, you get to the cropping screen. After adjusting the area, when I click on the validation button, it seems that nothing happens.
  • In fact, something is happening but on my phone this is very slow and I have no indication that processing is in progress.

Expected behavior

  • We should display a spinner to indicate action was taken into account and that processing is happening.

Why

  • The user might be disoriented, click several time on the validation button and think the app is broken.
@AshAman999
Copy link
Member

Can I work on this? Kinda new to open source but feels like i can handle this

@M123-dev
Copy link
Member

M123-dev commented Mar 17, 2022

Sure @AshAman999, and if you need any help, just ask

@teolemon
Copy link
Member

@AshAman999 before starting working, can you outline your plan here ?
In my opinion, we should avoid notifying the user during the upload, but rather once it's finished "Upload successful". If it fails, it should retry on its own later, once network is available.
As a user "Ongoing upload" is not useful. The UI should update immediately, and I should receive an unobtrusive hint of success afterwise.

@AshAman999
Copy link
Member

@teolemon I was simply going to do the approach as @M123-dev suggested, showing a loading spinner while the cropping is in process
Something like this

demo.mp4

Should I go ahead with something like this?
but as @teolemon suggested, if we have to do something like background uploading, I will have to study the codebase a bit more (kinda new here).
Please confirm which approach should I go for?

@M123-dev
Copy link
Member

@AshAman999 the way you showed in the video looks good for now. For me the issue is exactly about this. Offline upload is certainly great but we have more important tasks currently.

AshAman999 added a commit to AshAman999/smooth-app that referenced this issue Mar 19, 2022
AshAman999 added a commit to AshAman999/smooth-app that referenced this issue Mar 20, 2022
AshAman999 added a commit to AshAman999/smooth-app that referenced this issue Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants