-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking down the Profile Section into Multiple Pages/Tabs #1501
Comments
I do agree that the profile page is crowded. My suggestion is perhaps simpler than yours:
|
Indeed it is a very brilliant and minimalistic idea. I will work on implementing it and get back to you ✌️ |
@monsieurtanuki I am running into an error. For some reason, I am not able to make changes to the app_localizations.dart. Every time I add an element ' String get app_personalization; ' and run the app, my changes get reverted and it gives an error that app_personalization isn't defined. Can you guide me through what do I need to do to add new elements in app_localizations.dart. |
@Raj2503 I'm not an expert on localizations, but I'm pretty sure you should NOT edit If you want my opinion, don't bother with translations in a first approach: if ever we finally decide that your code stinks, you would have put confusion in the translation files, where each entry is replicated into dozens of language-specific files. |
@Raj2503 @monsieurtanuki here's a mockup. Consent toggles go in app settings, food preferences in food preferences, all the app settings to … app settings ;-) |
Thank you for the mockup @teolemon. Sure @monsieurtanuki, I have already some progress. Now that I have a mockup, I will have a greater overview to refer to. |
Marking as in progress as a result |
hey @Raj2503 , are you still working on this one ? |
@teolemon yeah I am implementing the idea you and @monsieurtanuki provided. I ran into the following error: The background of the new page section for App themes is not dynamically changing. I have not been able to work at my full pace due to my University exams. But I assure you I will get back to it straight away as soon as I am done with my exams. |
Hi @Raj2503! And it's not what you display in your animated GIF:
Basically it should take one hour max to code; I'm afraid you started in a wrong direction and over-engineered the whole thing. But first: study for you exams! |
Any updates @Raj2503 |
@Raj2503 If you don't mind I'll do it now. Don't worry: it was not the most interesting issue to code, and I'm sure that after you finish your exams there will be other issues to fix. |
… pages New file: * `abstract_collapsible_user_preferences.dart`: Abstraction of a collapsed/expanded display for the preference pages. Impacted files: * `abstract_user_preferences.dart`: refactoring around the fact that now we display pages instead of collapsible List<Widget> * `preferences_page.dart`: minor refactoring * `user_preferences_attribute_group.dart`: minor refactoring * `user_preferences_dev_mode.dart`: minor refactoring * `user_preferences_food.dart`: minor refactoring * `user_preferences_page.dart`: now we use the same `StatefulWidget` for a root page with only headers and detailed pages with bodies * `user_preferences_profile.dart`: minor refactoring * `user_preferences_settings.dart`: minor refactoring
Impacted files: * `user_preferences_page-blue-dark.dart`: impacted by new page design * `user_preferences_page-blue-light.dart`: impacted by new page design * `user_preferences_page-brown-dark.dart`: impacted by new page design * `user_preferences_page-brown-light.dart`: impacted by new page design * `user_preferences_page-green-dark.dart`: impacted by new page design * `user_preferences_page-green-light.dart`: impacted by new page design
…isual consistency Deleted files: * `faq_handle_view.dart` * `list_helper.dart` * `smooth_list_tile.dart` * `social_handle_view.dart` * `user_contribution_view.dart` New files: * `user_preferences_connect.dart`: Display of "Connect" for the preferences page. * `user_preferences_contribute.dart`: Display of "Contribute" for the preferences page. * `user_preferences_faq.dart`: Display of "FAQ" for the preferences page. * `user_preferences_list_tile.dart`: Custom `ListTile` for preferences. Impacted files: * `abstract_user_preferences.dart`: refactored around new class `UserPreferencesListTile`. * `user_preferences_page.dart`: created 3 new "top paragraphs" extracted from "settings". * `user_preferences_page-blue-dark.dart`: impacted by new page design. * `user_preferences_page-blue-light.dart`: impacted by new page design. * `user_preferences_page-brown-dark.dart`: impacted by new page design. * `user_preferences_page-brown-light.dart`: impacted by new page design. * `user_preferences_page-green-dark.dart`: impacted by new page design. * `user_preferences_page-green-light.dart`: impacted by new page design. * `user_preferences_settings.dart`: refactored code to 3 new "top paragraphs".
New file: * `all_user_product_list_page.dart`: Page that lists all user product lists. Impacted files: * `continuous_scan_model.dart`: refactored around `DaoProductList` being seldom `async` * `dao_product_list.dart`: new method `getLength`; refactored with less `async` methods * `new_product_page.dart`: refactored around `DaoProductList` being seldom `async` * `product_list_import_export.dart`: refactored around `DaoProductList` being seldom `async` * `product_list_page.dart`: refactored around `DaoProductList` being seldom `async` * `product_list_supplier.dart`: refactored around `DaoProductList` being seldom `async` * `product_list_user_dialog_helper.dart`: new "delete list?" dialog; refactored around `DaoProductList` being seldom `async` * `query_product_list_supplier.dart`: refactored around `DaoProductList` being seldom `async` * `user_preferences_list_tile.dart`: added field `onLongPress` * `user_preferences_settings.dart`: added items "Lists"
Impacted files: * `user_preferences_page.dart`: added item "Lists" * `user_preferences_settings.dart`: removed item "Lists" * `user_preferences_page-blue-dark.png`: impacted by new UI. * `user_preferences_page-blue-light.png`: impacted by new UI. * `user_preferences_page-brown-dark.png`: impacted by new UI. * `user_preferences_page-brown-light.png`: impacted by new UI. * `user_preferences_page-green-dark.png`: impacted by new UI. * `user_preferences_page-green-light.png`: impacted by new UI.
Deleted files: * `faq_handle_view.dart` * `list_helper.dart` * `smooth_list_tile.dart` * `social_handle_view.dart` * `user_contribution_view.dart` New files: * `abstract_collapsible_user_preferences.dart`: Abstraction of a collapsed/expanded display for the preference pages. * `all_user_product_list_page.dart`: Page that lists all user product lists. * `user_preferences_connect.dart`: Display of "Connect" for the preferences page. * `user_preferences_contribute.dart`: Display of "Contribute" for the preferences page. * `user_preferences_faq.dart`: Display of "FAQ" for the preferences page. * `user_preferences_list_tile.dart`: Custom `ListTile` for preferences. Impacted files: * `abstract_user_preferences.dart`: refactoring around the fact that now we display pages instead of collapsible List<Widget> * `continuous_scan_model.dart`: refactored around `DaoProductList` being seldom `async` * `dao_product_list.dart`: new method `getLength`; refactored with less `async` methods * `new_product_page.dart`: refactored around `DaoProductList` being seldom `async` * `preferences_page.dart`: minor refactoring * `product_list_import_export.dart`: refactored around `DaoProductList` being seldom `async` * `product_list_page.dart`: refactored around `DaoProductList` being seldom `async` * `product_list_supplier.dart`: refactored around `DaoProductList` being seldom `async` * `product_list_user_dialog_helper.dart`: new "delete list?" dialog; refactored around `DaoProductList` being seldom `async` * `query_product_list_supplier.dart`: refactored around `DaoProductList` being seldom `async` * `user_preferences_attribute_group.dart`: minor refactoring * `user_preferences_dev_mode.dart`: minor refactoring * `user_preferences_food.dart`: minor refactoring * `user_preferences_page.dart`: now we use the same `StatefulWidget` for a root page with only headers and detailed pages with bodies; added item "Lists"; created 3 new "top paragraphs" extracted from "settings". * `user_preferences_page-blue-dark.dart`: impacted by new page design * `user_preferences_page-blue-light.dart`: impacted by new page design * `user_preferences_page-brown-dark.dart`: impacted by new page design * `user_preferences_page-brown-light.dart`: impacted by new page design * `user_preferences_page-green-dark.dart`: impacted by new page design * `user_preferences_page-green-light.dart`: impacted by new page design * `user_preferences_profile.dart`: minor refactoring * `user_preferences_settings.dart`: minor refactoring
…edicated folders
Problem
As mentioned in Setting #960, the profile section has become over-clustered as it contains the following options:
Proposed solution
Separate the "User/App settings" and "User Food Preferences" in the bottom Navigation bar, shifting the App Settings like themes and sign-in options under the new tab.
So I was thinking of either creating a slider App-Drawer for settings or adding A New Button in BottomNavigation for the same.
Before starting off with the idea, I would like to discuss with the community whether to make the changes or not and also to take in more suggestions.
Part of
The text was updated successfully, but these errors were encountered: