Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button to finish picture cropping isn't visible (dark mode issue) #1826

Closed
Tracked by #513
, #684
...
M123-dev opened this issue May 12, 2022 · 3 comments · Fixed by #1845
Closed
Tracked by #513
, #684
...

Button to finish picture cropping isn't visible (dark mode issue) #1826

M123-dev opened this issue May 12, 2022 · 3 comments · Fixed by #1845
Labels
🐛 bug Something isn't working darkmode Ensuring we look good in the dark 🎯 P0 🖼️ Photos - Cropping
Milestone
V1

Comments

@M123-dev
Copy link
Member

M123-dev commented May 12, 2022 •
edited by teolemon

What

  • Button to finish picture cropping isn't visible (dark mode issue)

Part of

Screenshot

Screenshot_20220512-171800.jpg
@AshAman999
Copy link
Member

It probably needs some changes here #1800

Have you checked the changes for that pr on an actual device or emulator, sometimes emulator does give different results @vik4114,
Mind if possible you could have a look into this 😄

@vik4114
Copy link
Contributor

vik4114 commented May 12, 2022

It probably needs some changes here #1800

Have you checked the changes for that pr on an actual device or emulator, sometimes emulator does give different results @vik4114, Mind if possible you could have a look into this 😄

Okay I will look into it.

@teolemon teolemon mentioned this issue May 14, 2022
Open
1 task
@teolemon teolemon added this to the V1 milestone May 14, 2022
@teolemon teolemon added the darkmode Ensuring we look good in the dark label May 14, 2022
@teolemon
Copy link
Member

image

@teolemon teolemon mentioned this issue May 14, 2022
Closed
14 tasks
@teolemon teolemon changed the title No way to finish picture cropping No way to finish picture cropping (dark mode issue) May 14, 2022
@teolemon teolemon changed the title No way to finish picture cropping (dark mode issue) Button to finish picture cropping isn't visible (dark mode issue) May 14, 2022
@vik4114 vik4114 mentioned this issue May 14, 2022
Merged
M123-dev pushed a commit that referenced this issue May 14, 2022
@vik4114
fix: #1826 Changed text color according to mode (#1845)
04d5b42 
* changed colors

* formatted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working darkmode Ensuring we look good in the dark 🎯 P0 🖼️ Photos - Cropping
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging a pull request may close this issue.

fix: #1826 Changed text color according to mode vik4114/smooth-app
4 participants
@teolemon @M123-dev @vik4114 @AshAman999