Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explainers in all sections of edit mode #2574

Closed
teolemon opened this issue Jul 11, 2022 · 0 comments · Fixed by #2580
Closed

Add explainers in all sections of edit mode #2574

teolemon opened this issue Jul 11, 2022 · 0 comments · Fixed by #2580
Assignees
Labels
✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users

Comments

@teolemon
Copy link
Member

What

  • Add explainers in all sections of edit mode
  • Categories
    • "Indicate only the most specific category. Parent categories will be automatically added."
    • "In case a category is not available in autocomplete, feel free to add it anyway, that will help us improve Open Food Facts in your country."
    • "Examples: Sardines in olive oil, Orange juice from concentrate"
  • Packaging
    • "List all packaging parts separated by a comma or line feed, with their amount (e.g. 1 or 6) type (e.g. bottle, box, can), material (e.g. plastic, metal, aluminium) and if available their size (e.g. 33cl) and recycling instructions."
    • "Example: 1 glass bottle to recycle, 1 plastic cork to throw away"
  • Origins
    • Move the explainer outside the field
    • "Add any indications of origins you can find on the packaging. You need not worry about origins indicated directly in the ingredient list"
    • "Beef from Argentina, The soy does not come from the European Union"

Part of

Screenshots

  • image
  • image
  • image
@teolemon teolemon added ✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users labels Jul 11, 2022
@monsieurtanuki monsieurtanuki self-assigned this Jul 11, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 11, 2022
… and packaging

Impacted files:
* `app_en.arb`: populated explanation labels for origins, categories and packaging
* `app_fr.arb`: populated explanation labels for origins, categories and packaging
* `ocr_packaging_helper.dart`: unrelated refactoring "en passant"
* `simple_input_page.dart`: replaced subtitle by explanations
* `simple_input_page_helpers.dart`: populated explanations for origins and categories
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 11, 2022
New file:
* `explanation_widget.dart`: Widget that displays explanations as a list, with expand/collapse mode.

Impacted files:
* `edit_ingredients_page.dart`: now using new `ExplanationWidget`
* `simple_input_page.dart`: now using new `ExplanationWidget`
teolemon pushed a commit that referenced this issue Jul 11, 2022
#2580)

* feat: #2574 - added explanations for origins, categories and packaging

Impacted files:
* `app_en.arb`: populated explanation labels for origins, categories and packaging
* `app_fr.arb`: populated explanation labels for origins, categories and packaging
* `ocr_packaging_helper.dart`: unrelated refactoring "en passant"
* `simple_input_page.dart`: replaced subtitle by explanations
* `simple_input_page_helpers.dart`: populated explanations for origins and categories

* feat: #2574 - improved UI/UX

New file:
* `explanation_widget.dart`: Widget that displays explanations as a list, with expand/collapse mode.

Impacted files:
* `edit_ingredients_page.dart`: now using new `ExplanationWidget`
* `simple_input_page.dart`: now using new `ExplanationWidget`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users
Development

Successfully merging a pull request may close this issue.

2 participants