Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4595 - no fast track if nutriscore is not applicable #4599

Merged
merged 4 commits into from
Aug 26, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • We used to consider a product as incomplete in some cases, and displayed a "fast track" button in order to complete it.
  • But there are categories of products (e.g. alcool, coffee) that would always be considered as incomplete under those rules.
  • I've just added a test about the current nutriscore (computed by the server): if it's "not applicable", then we don't consider the product as incomplete and we don't display the fast-track button.

Screenshot

before after
Screenshot_2023-08-25-09-45-57 Screenshot_2023-08-25-09-49-38

Part of

@teolemon
Copy link
Member

@monsieurtanuki we have a parallel case for Eco-Score and drinks.
https://world.openfoodfacts.org/product/5449000206770/eau-de-table-ciel

@teolemon
Copy link
Member

Also, it would be very intesting to know how many times we show products with ecoscore not applicable, or nutriscore not applicable in matomo

@github-actions github-actions bot added the 📈 Analytics We use Sentry and Matomo, with an opt-in system label Aug 25, 2023
@monsieurtanuki
Copy link
Contributor Author

Also, it would be very intesting to know how many times we show products with ecoscore not applicable, or nutriscore not applicable in matomo

I've just added ecoscore and matomo.

@codecov-commenter
Copy link

Codecov Report

Merging #4599 (0adc984) into develop (3894656) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4599      +/-   ##
===========================================
- Coverage    10.27%   10.26%   -0.02%     
===========================================
  Files          297      297              
  Lines        15487    15506      +19     
===========================================
  Hits          1591     1591              
- Misses       13896    13915      +19     
Files Changed Coverage Δ
...kages/smooth_app/lib/helpers/analytics_helper.dart 6.25% <ø> (ø)
...app/lib/pages/product/product_incomplete_card.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon added the 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. label Aug 26, 2023
@monsieurtanuki monsieurtanuki merged commit 5bac720 into openfoodfacts:develop Aug 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system 🥫 Product page 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants