feat: 4513 - user preferences pages simple refactoring #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `user_preferences_advanced_settings.dart`: used to be `_AdvancedSettings` in `user_preferences_settings.dart` * `user_preferences_camera_sound.dart`: used to be `_CameraPlayScanSoundSetting` in `user_preferences_settings.dart` * `user_preferences_choose_accent_color.dart`: used to be `_ChooseAccentColor` in `user_preferences_settings.dart` * `user_preferences_choose_app_theme.dart`: used to be more or less `_ChooseAppTheme` in `user_preferences_settings.dart` * `user_preferences_choose_text_color_contrast.dart`: used to be `_ChooseTextColorContrast` in `user_preferences_settings.dart` * `user_preferences_country_selector.dart`: used to be coded in `user_preferences_settings.dart` * `user_preferences_crash_reporting.dart`: used to be `_CrashReportingSetting` in `user_preferences_settings.dart` * `user_preferences_haptic_feedback.dart`: used to be `_HapticFeedbackSetting` in `user_preferences_settings.dart` * `user_preferences_image_source.dart`: used to be coded in `user_preferences_settings.dart` * `user_preferences_language_selector.dart`: used to be coded in `user_preferences_settings.dart` * `user_preferences_rate_us.dart`: used to be `_RateUs` in `user_preferences_settings.dart` * `user_preferences_send_anonymous.dart`: used to be `_SendAnonymousDataSetting` in `user_preferences_settings.dart` * `user_preferences_share_with_friends.dart`: used to be `_ShareWithFriends` in `user_preferences_settings.dart` Impacted files: * `abstract_user_preferences.dart`: minor refactoring * `preferences_page.dart`: minor refactoring * `user_preferences.dart`: minor refactoring * `user_preferences_account.dart`: removed `UserPreferencesSection` and `_UserPreferencesAccountSubTitleSignOut` for simplification * `user_preferences_attribute_group.dart`: refactored as not `AbstractUserPreferences` * `user_preferences_connect.dart`: minor refactoring * `user_preferences_contribute.dart`: minor refactoring * `user_preferences_dev_mode.dart`: minor refactoring * `user_preferences_faq.dart`: minor refactoring * `user_preferences_food.dart`: minor refactoring * `user_preferences_page.dart`: minor refactoring * `user_preferences_settings.dart`: file was too big - moved code to new files+classes
github-actions
bot
added
the
🤗 Onboarding
Codecov Report
@@ Coverage Diff @@
## develop #4620 +/- ##
===========================================
- Coverage 10.13% 10.03% -0.11%
===========================================
Files 299 312 +13
Lines 15692 15637 -55
===========================================
- Hits 1591 1569 -22
+ Misses 14101 14068 -33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
I don't think it's a necessary change, but smaller files are a good idea and I am certain it'll help your refactoring. Thanks @monsieurtanuki 👍🏼
|
Thank you @M123-dev for your review! We do need it, and you'll see how in the next PR! 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
user_preferences_settings.dartthat was too big a file.Part of
Files
New files:
user_preferences_advanced_settings.dart: used to be_AdvancedSettingsinuser_preferences_settings.dartuser_preferences_camera_sound.dart: used to be_CameraPlayScanSoundSettinginuser_preferences_settings.dartuser_preferences_choose_accent_color.dart: used to be_ChooseAccentColorinuser_preferences_settings.dartuser_preferences_choose_app_theme.dart: used to be more or less_ChooseAppThemeinuser_preferences_settings.dartuser_preferences_choose_text_color_contrast.dart: used to be_ChooseTextColorContrastinuser_preferences_settings.dartuser_preferences_country_selector.dart: used to be coded inuser_preferences_settings.dartuser_preferences_crash_reporting.dart: used to be_CrashReportingSettinginuser_preferences_settings.dartuser_preferences_haptic_feedback.dart: used to be_HapticFeedbackSettinginuser_preferences_settings.dartuser_preferences_image_source.dart: used to be coded inuser_preferences_settings.dartuser_preferences_language_selector.dart: used to be coded inuser_preferences_settings.dartuser_preferences_rate_us.dart: used to be_RateUsinuser_preferences_settings.dartuser_preferences_send_anonymous.dart: used to be_SendAnonymousDataSettinginuser_preferences_settings.dartuser_preferences_share_with_friends.dart: used to be_ShareWithFriendsinuser_preferences_settings.dartImpacted files:
abstract_user_preferences.dart: minor refactoringpreferences_page.dart: minor refactoringuser_preferences.dart: minor refactoringuser_preferences_account.dart: removedUserPreferencesSectionand_UserPreferencesAccountSubTitleSignOutfor simplificationuser_preferences_attribute_group.dart: refactored as notAbstractUserPreferencesuser_preferences_connect.dart: minor refactoringuser_preferences_contribute.dart: minor refactoringuser_preferences_dev_mode.dart: minor refactoringuser_preferences_faq.dart: minor refactoringuser_preferences_food.dart: minor refactoringuser_preferences_page.dart: minor refactoringuser_preferences_settings.dart: file was too big - moved code to new files+classes