feat: 4513 - new "preferences search" page from dev mode #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted files: * `user_preferences_camera_sound.dart` * `user_preferences_crash_reporting.dart` * `user_preferences_haptic_feedback.dart` * `user_preferences_send_anonymous.dart` New files: * `user_preferences_item.dart`: Item for preferences, with labels for pre-filtering and widget builder. * `user_preferences_search_page.dart`: Search page for preferences, with TextField filter. Impacted files: * `abstract_user_preferences.dart`: new `getLabels` method for filtering; children are now `UserPreferencesItem` for filtering; minor refactoring. * `user_preferences_account.dart`: children are now `UserPreferencesItem`; minor refactoring * `user_preferences_advanced_settings.dart`: added a static `UserPreferencesItem` getter * `user_preferences_attribute_group.dart`: children are now `UserPreferencesItem`; minor refactoring * `user_preferences_choose_accent_color.dart`: added a static `UserPreferencesItem` getter * `user_preferences_choose_app_theme.dart`: added a static `UserPreferencesItem` getter * `user_preferences_choose_text_color_contrast.dart`: added a static `UserPreferencesItem` getter * `user_preferences_connect.dart`: children are now `UserPreferencesItem`; minor refactoring * `user_preferences_contribute.dart`: children are now `UserPreferencesItem`; minor refactoring * `user_preferences_country_selector.dart`: added a static `UserPreferencesItem` getter * `user_preferences_dev_mode.dart`: children are now `UserPreferencesItem`; minor refactoring * `user_preferences_faq.dart`: children are now `UserPreferencesItem`; minor refactoring * `user_preferences_food.dart`: children are now `UserPreferencesItem`; minor refactoring * `user_preferences_image_source.dart`: added a static `UserPreferencesItem` getter * `user_preferences_language_selector.dart`: added a static `UserPreferencesItem` getter * `user_preferences_page.dart`: moved `getUserPreferences` to `PreferencePageType`; minor refactoring * `user_preferences_rate_us.dart`: added a static `UserPreferencesItem` getter * `user_preferences_settings.dart`: children are now `UserPreferencesItem`; minor refactoring * `user_preferences_share_with_friends.dart`: added a static `UserPreferencesItem` getter * `user_preferences_widgets.dart`: new classes `UserPreferencesItemSwitch` and `UserPreferencesItemTile`
M123-dev
approved these changes
Sep 18, 2023
| final ThemeData themeData = Theme.of(context); | ||
| final ProductPreferences productPreferences = | ||
| context.read<ProductPreferences>(); | ||
| context.read<UserManagementProvider>(); |
| mainAxisAlignment: MainAxisAlignment.start, | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: <Widget>[ | ||
| TextField( |
There was a problem hiding this comment.
We should (if moved out of the dev mode) switch to the SmoothTextFormField
There was a problem hiding this comment.
We should (if moved out of the dev mode) switch to the SmoothTextFormField
Of course the UI/UX should be redesigned once the concept is approved and the code moved beyond the dev mode.
monsieurtanuki
commented
Sep 19, 2023
|
Thank you @M123-dev for your review!
I cannot really picture what the final UI/UX will look like, and we definitely need all settings to be translated if we only access settings via text search. |
|
I would restyle the search bar, like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
user_preferences_item.dartanduser_preferences_search_page.dart. The rest of the PR is just about preference pages that containUserPreferencesItems instead of mereWidgets.Screenshot
Part of
Files
Deleted files:
user_preferences_camera_sound.dartuser_preferences_crash_reporting.dartuser_preferences_haptic_feedback.dartuser_preferences_send_anonymous.dartNew files:
user_preferences_item.dart: Item for preferences, with labels for pre-filtering and widget builder.user_preferences_search_page.dart: Search page for preferences, with TextField filter.Impacted files:
abstract_user_preferences.dart: newgetLabelsmethod for filtering; children are nowUserPreferencesItemfor filtering; minor refactoring.user_preferences_account.dart: children are nowUserPreferencesItem; minor refactoringuser_preferences_advanced_settings.dart: added a staticUserPreferencesItemgetteruser_preferences_attribute_group.dart: children are nowUserPreferencesItem; minor refactoringuser_preferences_choose_accent_color.dart: added a staticUserPreferencesItemgetteruser_preferences_choose_app_theme.dart: added a staticUserPreferencesItemgetteruser_preferences_choose_text_color_contrast.dart: added a staticUserPreferencesItemgetteruser_preferences_connect.dart: children are nowUserPreferencesItem; minor refactoringuser_preferences_contribute.dart: children are nowUserPreferencesItem; minor refactoringuser_preferences_country_selector.dart: added a staticUserPreferencesItemgetteruser_preferences_dev_mode.dart: children are nowUserPreferencesItem; minor refactoringuser_preferences_faq.dart: children are nowUserPreferencesItem; minor refactoringuser_preferences_food.dart: children are nowUserPreferencesItem; minor refactoringuser_preferences_image_source.dart: added a staticUserPreferencesItemgetteruser_preferences_language_selector.dart: added a staticUserPreferencesItemgetteruser_preferences_page.dart: movedgetUserPreferencestoPreferencePageType; minor refactoringuser_preferences_rate_us.dart: added a staticUserPreferencesItemgetteruser_preferences_settings.dart: children are nowUserPreferencesItem; minor refactoringuser_preferences_share_with_friends.dart: added a staticUserPreferencesItemgetteruser_preferences_widgets.dart: new classesUserPreferencesItemSwitchandUserPreferencesItemTile