Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4655 - crashed with null brand in "add basic details page" #4659

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Just added a test and a fallback string if the brand is null in "add basic details page".

Screenshot

Screenshot_2023-09-25-19-10-43

Fixes bug(s)

@codecov-commenter
Copy link

Codecov Report

Merging #4659 (82e6c2e) into develop (53a75a3) will increase coverage by 9.91%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #4659      +/-   ##
==========================================
+ Coverage         0   9.91%   +9.91%     
==========================================
  Files            0     310     +310     
  Lines            0   15798   +15798     
==========================================
+ Hits             0    1566    +1566     
- Misses           0   14232   +14232     
Files Coverage Δ
..._app/lib/pages/product/add_basic_details_page.dart 0.00% <0.00%> (ø)

... and 309 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @monsieurtanuki 🆗

@monsieurtanuki monsieurtanuki merged commit 2b23dac into openfoodfacts:develop Sep 28, 2023
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grey screen on basic details edition
3 participants