Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The loading preview (shimmer) doesn't use the correct layout #4668

Closed
g123k opened this issue Sep 29, 2023 · 3 comments · Fixed by #4680 or #4522
Closed

The loading preview (shimmer) doesn't use the correct layout #4668

g123k opened this issue Sep 29, 2023 · 3 comments · Fixed by #4680 or #4522
Assignees
@WildOrangutan
Labels
🐛 bug Something isn't working good first issue Good for newcomers 🔎 Search

Comments

@g123k
Copy link
Collaborator

g123k commented Sep 29, 2023

Hi everyone,

When we search for something, we may have multiple pages of results.
During the fetch of the next page, we show a shimmered version of a card.
However, the two lines in the middle don't have the correct design.
We should instead have :

  • Three lines
  • The same layout (top / middle / bottom)

vlcsnap-2023-09-29-21h28m07s196

Video:
https://github.com/openfoodfacts/smooth-app/assets/246838/a5e2ab6e-207c-4acc-8b06-fc9f40e71f94
@g123k g123k added 🐛 bug Something isn't working good first issue Good for newcomers 🔎 Search labels Sep 29, 2023
@WildOrangutan
Copy link
Contributor

I can fix this

@malik-vishu
Copy link
Contributor

malik-vishu commented Oct 1, 2023 •
edited

@teolemon @monsieurtanuki Can you please assign this to me?

@monsieurtanuki
Copy link
Contributor

@malik-vishu Sorry about that, but @WildOrangutan was there first 😉

WildOrangutan added a commit to WildOrangutan/smooth-app that referenced this issue Oct 2, 2023
@WildOrangutan
fix: Product card template
6bc6dea 
Adjust product card template, to better match product card.

Fixes openfoodfacts#4668
@WildOrangutan WildOrangutan mentioned this issue Oct 2, 2023
Merged
M123-dev pushed a commit that referenced this issue Oct 4, 2023
@WildOrangutan
fix: Product card template (#4680)
8ac2fa9 
Adjust product card template, to better match product card.

Fixes #4668
@github-actions github-actions bot mentioned this issue Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WildOrangutan WildOrangutan

Labels
🐛 bug Something isn't working good first issue Good for newcomers 🔎 Search
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
4 participants
@g123k @WildOrangutan @monsieurtanuki @malik-vishu