Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort attributes inside a group based on how important the attribute is for the user. #657

Closed
Tracked by #655
monsieurtanuki opened this issue Nov 14, 2021 · 1 comment · Fixed by #658 or #665
Closed
Tracked by #655

Sort attributes inside a group based on how important the attribute is for the user. #657

monsieurtanuki opened this issue Nov 14, 2021 · 1 comment · Fixed by #658 or #665
Assignees
@monsieurtanuki

Comments

@monsieurtanuki
Copy link
Contributor

No description provided.

@monsieurtanuki monsieurtanuki self-assigned this Nov 14, 2021
@monsieurtanuki monsieurtanuki mentioned this issue Nov 14, 2021
Closed
42 tasks
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 14, 2021
@monsieurtanuki
feat: openfoodfacts#657 - important attributes first, and then ordere…
0cd4182 
…d and filtered attributes

Impacted file:
* `summary_card.dart`: new methods `_getMandatoryAttributeIds` and `_getOrderedAndFilteredAttributes`
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 16, 2021
@monsieurtanuki
feat: openfoodfacts#657 - nutriscore+ecoscore, then mandatory attribu…
338779c 
…tes, then groups

Impacted file:
* `summary_card.dart`: put back nutriscore and ecoscore on top; added environment group (so far, only forest_footprint); added a virtual group for mandatory attributes on top of the "normal" attribute groups
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 16, 2021
@monsieurtanuki
feat: openfoodfacts#657 - simple refactoring after code review
ea326ef
monsieurtanuki added a commit that referenced this issue Nov 16, 2021
@monsieurtanuki
feat: #657 - nutriscore+ecoscore, then mandatory attributes, then gro…
09a21c3 
…ups and important attributes (#658)

Impacted file:
* `summary_card.dart`: new methods `_getMandatoryAttributeIds` and `_getOrderedAndFilteredAttributes`; added environment group (so far, only forest_footprint); added a virtual group for mandatory attributes on top of the "normal" attribute groups
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 16, 2021
@monsieurtanuki
feat: openfoodfacts#657 (2) - same behavior for label attribute when …
8972e54 
…mandatory or not

Impacted file:
* `summary_card.dart`: compute the list of label attributes, to be used in both mandatory and label groups
monsieurtanuki added a commit that referenced this issue Nov 17, 2021
@monsieurtanuki
feat: #657 (2) - same behavior for label attribute when mandatory or …
2f6a38d 
…not (#665)

Impacted file:
* `summary_card.dart`: compute the list of label attributes, to be used in both mandatory and label groups
@monsieurtanuki
Copy link
Contributor Author

Done in #658 and #665.

This was linked to pull requests Nov 25, 2021
feat: #657 - important attributes first, and then ordered and filtered attributes #658
Merged
feat: #657 (2) - same behavior for label attribute when mandatory or not #665
Merged
@github-actions github-actions bot mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@monsieurtanuki