Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of possible preference options from 4 to 3. "Mandatory", "Important", "Don't care". #671

Closed
Tracked by #655
monsieurtanuki opened this issue Nov 18, 2021 · 4 comments · Fixed by #672
Closed
Tracked by #655

Reduce the number of possible preference options from 4 to 3. "Mandatory", "Important", "Don't care". #671

monsieurtanuki opened this issue Nov 18, 2021 · 4 comments · Fixed by #672
Assignees
@monsieurtanuki

Comments

@monsieurtanuki
Copy link
Contributor

No description provided.

@monsieurtanuki monsieurtanuki mentioned this issue Nov 18, 2021
Closed
42 tasks
@jasmeet0817
Copy link
Contributor

Thanks @monsieurtanuki

I had a chat with Stephane, the plan here would be to collapse "Important" and "Very Important" into Important. No change in dart package. From the UI's standoint, we can keep the current behavior (show a selector with the three prefs and the user selects one of them).

@monsieurtanuki
Copy link
Contributor Author

That means we can remove #492, can't we?

@jasmeet0817
Copy link
Contributor

yeah, that PR can rest in peace

@monsieurtanuki monsieurtanuki mentioned this issue Nov 18, 2021
Closed
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 18, 2021
@monsieurtanuki
feat: openfoodfacts#671 - removed the "very important" attribute impo…
814cb23 
…rtance

Deleted file:
* `very_important.svg`

Impacted files:
* `attribute_button.dart`: removed "very important" as a possibility and downgraded it to "important"
* `mandatory.svg`: used to be "!!!", now just "!!" is enough
* `product_compatibility_helper.dart`: downgraded the "very important" weight to the "important" weight value
* `product_preferences.dart`: the default attributes are now reset to "important" (instead of "very important")
* `summary_card.dart`: removed the "very important" option and simplified the code accordingly
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 18, 2021
@monsieurtanuki
feat: openfoodfacts#671 - github magic trick
da31f5c
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 18, 2021
@monsieurtanuki
Revert "feat: openfoodfacts#671 - removed the "very important" attrib…
cda6220 
…ute importance"

This reverts commit 814cb23
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 18, 2021
@monsieurtanuki
feat: openfoodfacts#671 - removed the "very important" attribute impo…
affc8c9 
…rtance

Deleted file:
* `very_important.svg`

Impacted files:
* `attribute_button.dart`: removed "very important" as a possibility and downgraded it to "important"
* `mandatory.svg`: used to be "!!!", now just "!!" is enough
* `product_compatibility_helper.dart`: downgraded the "very important" weight to the "important" weight value
* `product_preferences.dart`: the default attributes are now reset to "important" (instead of "very important")
monsieurtanuki added a commit that referenced this issue Nov 18, 2021
@monsieurtanuki
feat: #671 - removed the "very important" attribute importance (#672)
69bdefb 
Deleted file:
* `very_important.svg`

Impacted files:
* `attribute_button.dart`: removed "very important" as a possibility and downgraded it to "important"
* `mandatory.svg`: used to be "!!!", now just "!!" is enough
* `product_compatibility_helper.dart`: downgraded the "very important" weight to the "important" weight value
* `product_preferences.dart`: the default attributes are now reset to "important" (instead of "very important")
@monsieurtanuki
Copy link
Contributor Author

Closed with #672.

@monsieurtanuki monsieurtanuki mentioned this issue Nov 25, 2021
Merged
@monsieurtanuki monsieurtanuki self-assigned this Nov 25, 2021
@monsieurtanuki monsieurtanuki linked a pull request Nov 25, 2021 that will close this issue
feat: #671 - removed the "very important" attribute importance #672
Merged
@monsieurtanuki monsieurtanuki mentioned this issue Dec 23, 2021
Closed
@github-actions github-actions bot mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #671 - removed the "very important" attribute importance monsieurtanuki/smooth-app
2 participants
@jasmeet0817 @monsieurtanuki