Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tabs stateful. I.e., if you navigate away from a tab and come back you should come back to the state in which you left the tab. Clicking on the tab again should reset the tab state. #681

Closed
Tracked by #655
monsieurtanuki opened this issue Nov 25, 2021 · 0 comments · Fixed by #703
Closed
Tracked by #655

Make tabs stateful. I.e., if you navigate away from a tab and come back you should come back to the state in which you left the tab. Clicking on the tab again should reset the tab state. #681

monsieurtanuki opened this issue Nov 25, 2021 · 0 comments · Fixed by #703
Assignees
@M123-dev

Comments

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Nov 25, 2021 •
edited

cf. #679 (comment) by @jasmeet0817:

  • Navigation bar becomes sticky
  • If the user goes into a tab and clicks around (example: opens the product page from history tab), he is still in that tab, just browsing
  • Tabs are sticky, so lets say a user is on the "Product page" from the "History tab", he clicks on "Preferences tab", then clicks back on the "History tab", he will land on the "Product page" he was recently viewing, rather than on the "history page". Tapping again on the History tab will take the user to the "History page". This behavior is akin to a few other apps like Gmail/parts of GMaps etc.
  • When the user opens the app, the first tab displayed to the user is always the Scan page.
@monsieurtanuki monsieurtanuki mentioned this issue Nov 25, 2021
Closed
42 tasks
@M123-dev M123-dev self-assigned this Nov 26, 2021
@M123-dev M123-dev linked a pull request Dec 4, 2021 that will close this issue
feat: #681 Stateful tabs #703
Merged
M123-dev added a commit that referenced this issue Dec 11, 2021
@M123-dev @monsieurtanuki
feat: #681 Stateful tabs (#703)
ca3739e 
* feat: first working stateful tab

* feat: enum instead of String

* Update tab_navigator.dart

* feat: Working camera disable for other tabs

* fix: #640 stop camera when navigating further in the stack

* doc + null safety

* fix: activating scanner when rebuilding from ground up

* Updated goldens

The navbar got removed from the images because it is now not directly added by the pages anymore

* doc:

* Minor changes

* fix: Updating product with multiple navigators

* Minor fixes

* Simplification

* Simplification

* Simplification

* Update main.dart

* Update product_list_page.dart

Co-authored-by: monsieurtanuki <fabrice_fontaine@hotmail.com>
@github-actions github-actions bot mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@M123-dev M123-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #681 Stateful tabs openfoodfacts/smooth-app
2 participants
@monsieurtanuki @M123-dev